Page MenuHomePhabricator

Include invoke'd functions for recursive extract
ClosedPublic

Authored by david2050 on Apr 3 2019, 1:17 PM.

Details

Summary

When recursively extracting a function from a bit code file, include functions mentioned in InvokeInst as well as CallInst

Diff Detail

Repository
rL LLVM

Event Timeline

david2050 created this revision.Apr 3 2019, 1:17 PM
Herald added a project: Restricted Project. · View Herald TranscriptApr 3 2019, 1:17 PM

Inline comment on implementation. The functionality looks fine to me.

tools/llvm-extract/llvm-extract.cpp
274 ↗(On Diff #193579)

Just use CallBase here instead of enumerating the subclasses thereof?
Also the formatting, looks slightly off.

david2050 updated this revision to Diff 193784.Apr 4 2019, 2:25 PM

use CallBase

loladiro accepted this revision.Apr 4 2019, 2:42 PM
loladiro added inline comments.
tools/llvm-extract/llvm-extract.cpp
277 ↗(On Diff #193784)

nit: The Function * can just remain here.

This revision is now accepted and ready to land.Apr 4 2019, 2:42 PM
david2050 updated this revision to Diff 193804.Apr 4 2019, 4:25 PM
david2050 marked an inline comment as done.

cleanup

This revision was automatically updated to reflect the committed changes.