This is an archive of the discontinued LLVM Phabricator instance.

Paths

[yaml2obj] - Check we correctly set the sh_info field of .symtab section.
ClosedPublic

Authored by grimar on Apr 3 2019, 3:57 AM.

Reviewers

jhenderson

Commits

Summary

initSymtabSectionHeader has the following line:
SHeader.sh_info = findLocalsNum(Symbols) + 1;

As was mentioned in a review comments for D60122,
it is never tested. The patch adds a test.

test/tools/yaml2obj/local-symbols.yaml
35	Could you add a non-local symbol for completeness, please?

LGTM.

This revision is now accepted and ready to land.Apr 3 2019, 5:43 AM

This revision was automatically updated to reflect the committed changes.

Path

Size

test/

tools/

yaml2obj/

38 lines

				# Check we correctly set the sh_info field of .symtab section.
				# A symbol table section's sh_info section header member holds
				# the symbol table index for the first non-local symbol.

				# RUN: yaml2obj -docnum=1 %s -o %t
				# RUN: llvm-readobj -sections %t \| FileCheck %s --check-prefix=ONE
				# ONE: Name: .symtab
				# ONE: Info: 2

				--- !ELF
				FileHeader:
				Class: ELFCLASS64
				Data: ELFDATA2LSB
				Type: ET_DYN
				Machine: EM_X86_64
				Symbols:
				Local:
				- Name: local
				Global:
				- Name: global

				# RUN: yaml2obj -docnum=2 %s -o %t
				# RUN: llvm-readobj -sections %t \| FileCheck %s --check-prefix=TWO
				# TWO: Name: .symtab
				# TWO: Info: 3

				--- !ELF
				FileHeader:
				Class: ELFCLASS64
				Data: ELFDATA2LSB
				Type: ET_DYN
				Machine: EM_X86_64
				Symbols:
				Local:
				- Name: local1
				jhendersonUnsubmitted Done Reply Inline Actions Could you add a non-local symbol for completeness, please? jhenderson: Could you add a non-local symbol for completeness, please?
				- Name: local2
				Global:
				- Name: global