This is an archive of the discontinued LLVM Phabricator instance.

[yaml2obj] - Check we correctly set the sh_info field of .symtab section.
ClosedPublic

Authored by grimar on Apr 3 2019, 3:57 AM.

Details

Summary

initSymtabSectionHeader has the following line:
SHeader.sh_info = findLocalsNum(Symbols) + 1;

As was mentioned in a review comments for D60122,
it is never tested. The patch adds a test.

Diff Detail

Repository
rL LLVM

Event Timeline

grimar created this revision.Apr 3 2019, 3:57 AM
jhenderson added inline comments.Apr 3 2019, 4:58 AM
test/tools/yaml2obj/local-symbols.yaml
34 ↗(On Diff #193464)

Could you add a non-local symbol for completeness, please?

grimar updated this revision to Diff 193477.Apr 3 2019, 5:42 AM
grimar marked an inline comment as done.
  • Addressed review comments.
This revision is now accepted and ready to land.Apr 3 2019, 5:43 AM
This revision was automatically updated to reflect the committed changes.
Herald added a project: Restricted Project. · View Herald TranscriptApr 4 2019, 4:48 AM