This is an archive of the discontinued LLVM Phabricator instance.

Differential D59915

Convert SymbolFilePDB::CompleteType to get the typesystem from the arg
AbandonedPublic

Authored by lanza on Mar 27 2019, 8:51 PM.

Details

Reviewers
None
Summary

Instead of assuming a ClangASTContext we just get the TypeSystem from
the argument CompilerType.

Diff Detail

Event Timeline

lanza created this revision.Mar 27 2019, 8:51 PM
Herald added a subscriber: jdoerfert. · View Herald TranscriptMar 27 2019, 8:51 PM
Harbormaster completed remote builds in B29727: Diff 192559.Mar 27 2019, 8:52 PM
lanza updated this revision to Diff 192729.Mar 28 2019, 3:19 PM

rebase

Harbormaster completed remote builds in B29776: Diff 192729.Mar 28 2019, 3:20 PM
lanza abandoned this revision.Jun 29 2019, 6:05 PM

Revision Contents

PathSize
source/
Plugins/
SymbolFile/
PDB/
11 lines

Diff 192729

source/Plugins/SymbolFile/PDB/SymbolFilePDB.cpp

Show First 20 Lines • Show All 591 Lines • ▼ Show 20 Linesllvm::Optional<SymbolFile::ArrayInfo> SymbolFilePDB::GetDynamicArrayInfoForUID(
lldb::user_id_t type_uid, const lldb_private::ExecutionContext *exe_ctx) { lldb::user_id_t type_uid, const lldb_private::ExecutionContext *exe_ctx) {
return llvm::None; return llvm::None;
} }
bool SymbolFilePDB::CompleteType(lldb_private::CompilerType &compiler_type) { bool SymbolFilePDB::CompleteType(lldb_private::CompilerType &compiler_type) {
std::lock_guard<std::recursive_mutex> guard( std::lock_guard<std::recursive_mutex> guard(
GetObjectFile()->GetModule()->GetMutex()); GetObjectFile()->GetModule()->GetMutex());
ClangASTContext *clang_ast_ctx = llvm::dyn_cast_or_null<ClangASTContext>( TypeSystem *type_system = compiler_type.GetTypeSystem();
GetTypeSystemForLanguage(lldb::eLanguageTypeC_plus_plus)); PDBASTParser *pdb = type_system->GetPDBParser();
if (!clang_ast_ctx)
return false;
PDBASTParser *pdb = clang_ast_ctx->GetPDBParser();
if (!pdb) if (!pdb)
return false; llvm_unreachable("FIXME");
//return false;
return pdb->CompleteTypeFromPDB(compiler_type); return pdb->CompleteTypeFromPDB(compiler_type);
} }
lldb_private::CompilerDecl SymbolFilePDB::GetDeclForUID(lldb::user_id_t uid) { lldb_private::CompilerDecl SymbolFilePDB::GetDeclForUID(lldb::user_id_t uid) {
ClangASTContext *clang_ast_ctx = llvm::dyn_cast_or_null<ClangASTContext>( ClangASTContext *clang_ast_ctx = llvm::dyn_cast_or_null<ClangASTContext>(
GetTypeSystemForLanguage(lldb::eLanguageTypeC_plus_plus)); GetTypeSystemForLanguage(lldb::eLanguageTypeC_plus_plus));
if (!clang_ast_ctx) if (!clang_ast_ctx)
▲ Show 20 Lines • Show All 1,417 Lines • Show Last 20 Lines