This is an archive of the discontinued LLVM Phabricator instance.

[Driver] Pass -malign-double from the driver to the cc1 command line
ClosedPublic

Authored by craig.topper on Mar 20 2019, 5:46 PM.

Details

Summary

-malign-double is currently only implemented in the -cc1 interface. But its declared in Options.td so it is a driver option too. But you try to use it with the driver you'll get a message about the option being unused.

This patch teaches the driver to pass the option through to cc1 so it won't be unused. The Options.td says the option is x86 only but I didn't see any x86 specific code in its impementation in cc1 so not sure if the documentation is wrong or if I should only pass this option through the driver on x86 targets.

Diff Detail

Repository
rL LLVM

Event Timeline

craig.topper created this revision.Mar 20 2019, 5:46 PM
rnk accepted this revision.Mar 21 2019, 10:56 AM

lgtm

This revision is now accepted and ready to land.Mar 21 2019, 10:56 AM
This revision was automatically updated to reflect the committed changes.
Herald added a project: Restricted Project. · View Herald TranscriptMar 21 2019, 1:06 PM