This is an archive of the discontinued LLVM Phabricator instance.

lld-link: Run conflict-mangled.test on all systems
ClosedPublic

Authored by thakis on Mar 18 2019, 9:45 AM.

Download Raw Diff

Details

Reviewers

Commits

rG2b1dca79f201: lld-link: Run conflict-mangled.test on all systems
rL356380: lld-link: Run conflict-mangled.test on all systems
rLLD356380: lld-link: Run conflict-mangled.test on all systems

Summary

It seems to pass fine on my Mac, and it running it only on Windows made me miss it in rL355959 and required rL355959.

Diff Detail

Event Timeline

thakis created this revision.Mar 18 2019, 9:45 AM

Herald added a project: Restricted Project. · View Herald TranscriptMar 18 2019, 9:45 AM

LGTM

This revision is now accepted and ready to land.Mar 18 2019, 9:47 AM

Ah, it was here because when rL288992 was written we still used UnDecorateSymbolName() for demangling. Now we use LLVM's microsoftDemangle() which is cross-platform.

Closed by commit rLLD356380: lld-link: Run conflict-mangled.test on all systems (authored by nico). · Explain WhyMar 18 2019, 9:50 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents

Path

Size

lld/

test/

COFF/

conflict-mangled.test

1 line

Diff 191116

lld/test/COFF/conflict-mangled.test

	# REQUIRES: system-windows
	# RUN: yaml2obj < %s > %t1.obj			# RUN: yaml2obj < %s > %t1.obj
	# RUN: yaml2obj < %s > %t2.obj			# RUN: yaml2obj < %s > %t2.obj
	# RUN: not lld-link /out:%t.exe %t1.obj %t2.obj >& %t.log			# RUN: not lld-link /out:%t.exe %t1.obj %t2.obj >& %t.log
	# RUN: FileCheck %s < %t.log			# RUN: FileCheck %s < %t.log
	# RUN: not lld-link /out:%t.exe /demangle %t1.obj %t2.obj 2>&1 \| FileCheck %s			# RUN: not lld-link /out:%t.exe /demangle %t1.obj %t2.obj 2>&1 \| FileCheck %s
	# RUN: not lld-link /out:%t.exe /demangle:no %t1.obj %t2.obj 2>&1 \| FileCheck --check-prefix=NODEMANGLE %s			# RUN: not lld-link /out:%t.exe /demangle:no %t1.obj %t2.obj 2>&1 \| FileCheck --check-prefix=NODEMANGLE %s

	# NODEMANGLE: duplicate symbol: ?mangled@@YAHXZ in {{.+}}1.obj and in {{.+}}2.obj			# NODEMANGLE: duplicate symbol: ?mangled@@YAHXZ in {{.+}}1.obj and in {{.+}}2.obj
	Show All 32 Lines