This is an archive of the discontinued LLVM Phabricator instance.

Differential D59476

[InstCombine] Improve with.overflow intrinsic tests
ClosedPublic

Authored by dlrobertson on Mar 17 2019, 12:01 PM.

Details

Reviewers
lebedev.ri
Commits
rGc1d4fc8a6258: [InstCombine] Improve with.overflow intrinsic tests; NFC
rL356403: [InstCombine] Improve with.overflow intrinsic tests; NFC
Summary
  • Do not use unnamed values in saddo tests
  • Add tests for canonicalization of a constant arg0

Diff Detail

Event Timeline

dlrobertson created this revision.Mar 17 2019, 12:01 PM
Herald added a project: Restricted Project. · View Herald TranscriptMar 17 2019, 12:01 PM
Herald added a subscriber: llvm-commits. · View Herald Transcript
lebedev.ri accepted this revision.Mar 17 2019, 12:06 PM

This is NFC, no real need for review.

This revision is now accepted and ready to land.Mar 17 2019, 12:06 PM
dlrobertson updated this revision to Diff 191033.Mar 17 2019, 12:06 PM
  • Add plain add test
Closed by commit rL356403: [InstCombine] Improve with.overflow intrinsic tests; NFC (authored by nikic). · Explain WhyMar 18 2019, 1:08 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents

PathSize
llvm/
test/
Transforms/
InstCombine/
116 lines
54 lines

Diff 191030

llvm/test/Transforms/InstCombine/sadd-with-overflow.ll

; NOTE: Assertions have been autogenerated by utils/update_test_checks.py ; NOTE: Assertions have been autogenerated by utils/update_test_checks.py
; RUN: opt < %s -instcombine -S | FileCheck %s ; RUN: opt < %s -instcombine -S | FileCheck %s
declare { <2 x i32>, <2 x i1> } @llvm.sadd.with.overflow.v2i32(<2 x i32>, <2 x i32>) declare { <2 x i32>, <2 x i1> } @llvm.sadd.with.overflow.v2i32(<2 x i32>, <2 x i32>)
declare { i32, i1 } @llvm.sadd.with.overflow.i32(i32, i32) declare { i32, i1 } @llvm.sadd.with.overflow.i32(i32, i32)
declare { i8, i1 } @llvm.sadd.with.overflow.i8(i8, i8) declare { i8, i1 } @llvm.sadd.with.overflow.i8(i8, i8)
define { i32, i1 } @simple_fold(i32) { define { i32, i1 } @simple_fold(i32 %x) {
; CHECK-LABEL: @simple_fold( ; CHECK-LABEL: @simple_fold(
; CHECK-NEXT: [[TMP2:%.*]] = call { i32, i1 } @llvm.sadd.with.overflow.i32(i32 [[TMP0:%.*]], i32 20) ; CHECK-NEXT: [[TMP1:%.*]] = call { i32, i1 } @llvm.sadd.with.overflow.i32(i32 [[X:%.*]], i32 20)
; CHECK-NEXT: ret { i32, i1 } [[TMP2]] ; CHECK-NEXT: ret { i32, i1 } [[TMP1]]
; ;
%2 = add nsw i32 %0, 7 %a = add nsw i32 %x, 7
%3 = tail call { i32, i1 } @llvm.sadd.with.overflow.i32(i32 %2, i32 13) %b = tail call { i32, i1 } @llvm.sadd.with.overflow.i32(i32 %a, i32 13)
ret { i32, i1 } %3 ret { i32, i1 } %b
} }
define { i32, i1 } @fold_mixed_signs(i32) { define { i32, i1 } @fold_mixed_signs(i32 %x) {
; CHECK-LABEL: @fold_mixed_signs( ; CHECK-LABEL: @fold_mixed_signs(
; CHECK-NEXT: [[TMP2:%.*]] = call { i32, i1 } @llvm.sadd.with.overflow.i32(i32 [[TMP0:%.*]], i32 6) ; CHECK-NEXT: [[TMP1:%.*]] = call { i32, i1 } @llvm.sadd.with.overflow.i32(i32 [[X:%.*]], i32 6)
; CHECK-NEXT: ret { i32, i1 } [[TMP2]] ; CHECK-NEXT: ret { i32, i1 } [[TMP1]]
; ;
%2 = add nsw i32 %0, 13 %a = add nsw i32 %x, 13
%3 = tail call { i32, i1 } @llvm.sadd.with.overflow.i32(i32 %2, i32 -7) %b = tail call { i32, i1 } @llvm.sadd.with.overflow.i32(i32 %a, i32 -7)
ret { i32, i1 } %3 ret { i32, i1 } %b
} }
define { i8, i1 } @fold_on_constant_add_no_overflow(i8) { define { i8, i1 } @fold_on_constant_add_no_overflow(i8 %x) {
; CHECK-LABEL: @fold_on_constant_add_no_overflow( ; CHECK-LABEL: @fold_on_constant_add_no_overflow(
; CHECK-NEXT: [[TMP2:%.*]] = call { i8, i1 } @llvm.sadd.with.overflow.i8(i8 [[TMP0:%.*]], i8 127) ; CHECK-NEXT: [[TMP1:%.*]] = call { i8, i1 } @llvm.sadd.with.overflow.i8(i8 [[X:%.*]], i8 127)
; CHECK-NEXT: ret { i8, i1 } [[TMP2]] ; CHECK-NEXT: ret { i8, i1 } [[TMP1]]
; ;
%2 = add nsw i8 %0, 100 %a = add nsw i8 %x, 100
%3 = tail call { i8, i1 } @llvm.sadd.with.overflow.i8(i8 %2, i8 27) %b = tail call { i8, i1 } @llvm.sadd.with.overflow.i8(i8 %a, i8 27)
ret { i8, i1 } %3 ret { i8, i1 } %b
} }
define { i8, i1 } @no_fold_on_constant_add_overflow(i8) { define { i8, i1 } @no_fold_on_constant_add_overflow(i8 %x) {
; CHECK-LABEL: @no_fold_on_constant_add_overflow( ; CHECK-LABEL: @no_fold_on_constant_add_overflow(
; CHECK-NEXT: [[TMP2:%.*]] = add nsw i8 [[TMP0:%.*]], 100 ; CHECK-NEXT: [[A:%.*]] = add nsw i8 [[X:%.*]], 100
; CHECK-NEXT: [[TMP3:%.*]] = tail call { i8, i1 } @llvm.sadd.with.overflow.i8(i8 [[TMP2]], i8 28) ; CHECK-NEXT: [[B:%.*]] = tail call { i8, i1 } @llvm.sadd.with.overflow.i8(i8 [[A]], i8 28)
; CHECK-NEXT: ret { i8, i1 } [[TMP3]] ; CHECK-NEXT: ret { i8, i1 } [[B]]
; ;
%2 = add nsw i8 %0, 100 %a = add nsw i8 %x, 100
%3 = tail call { i8, i1 } @llvm.sadd.with.overflow.i8(i8 %2, i8 28) %b = tail call { i8, i1 } @llvm.sadd.with.overflow.i8(i8 %a, i8 28)
ret { i8, i1 } %3 ret { i8, i1 } %b
} }
define { <2 x i32>, <2 x i1> } @fold_simple_splat_constant(<2 x i32>) { define { <2 x i32>, <2 x i1> } @fold_simple_splat_constant(<2 x i32> %x) {
; CHECK-LABEL: @fold_simple_splat_constant( ; CHECK-LABEL: @fold_simple_splat_constant(
; CHECK-NEXT: [[TMP2:%.*]] = call { <2 x i32>, <2 x i1> } @llvm.sadd.with.overflow.v2i32(<2 x i32> [[TMP0:%.*]], <2 x i32> <i32 42, i32 42>) ; CHECK-NEXT: [[TMP1:%.*]] = call { <2 x i32>, <2 x i1> } @llvm.sadd.with.overflow.v2i32(<2 x i32> [[X:%.*]], <2 x i32> <i32 42, i32 42>)
; CHECK-NEXT: ret { <2 x i32>, <2 x i1> } [[TMP2]] ; CHECK-NEXT: ret { <2 x i32>, <2 x i1> } [[TMP1]]
; ;
%2 = add nsw <2 x i32> %0, <i32 12, i32 12> %a = add nsw <2 x i32> %x, <i32 12, i32 12>
%3 = tail call { <2 x i32>, <2 x i1> } @llvm.sadd.with.overflow.v2i32(<2 x i32> %2, <2 x i32> <i32 30, i32 30>) %b = tail call { <2 x i32>, <2 x i1> } @llvm.sadd.with.overflow.v2i32(<2 x i32> %a, <2 x i32> <i32 30, i32 30>)
ret { <2 x i32>, <2 x i1> } %3 ret { <2 x i32>, <2 x i1> } %b
} }
define { <2 x i32>, <2 x i1> } @no_fold_splat_undef_constant(<2 x i32>) { define { <2 x i32>, <2 x i1> } @no_fold_splat_undef_constant(<2 x i32> %x) {
; CHECK-LABEL: @no_fold_splat_undef_constant( ; CHECK-LABEL: @no_fold_splat_undef_constant(
; CHECK-NEXT: [[TMP2:%.*]] = add nsw <2 x i32> [[TMP0:%.*]], <i32 12, i32 undef> ; CHECK-NEXT: [[A:%.*]] = add nsw <2 x i32> [[X:%.*]], <i32 12, i32 undef>
; CHECK-NEXT: [[TMP3:%.*]] = tail call { <2 x i32>, <2 x i1> } @llvm.sadd.with.overflow.v2i32(<2 x i32> [[TMP2]], <2 x i32> <i32 30, i32 30>) ; CHECK-NEXT: [[B:%.*]] = tail call { <2 x i32>, <2 x i1> } @llvm.sadd.with.overflow.v2i32(<2 x i32> [[A]], <2 x i32> <i32 30, i32 30>)
; CHECK-NEXT: ret { <2 x i32>, <2 x i1> } [[TMP3]] ; CHECK-NEXT: ret { <2 x i32>, <2 x i1> } [[B]]
; ;
%2 = add nsw <2 x i32> %0, <i32 12, i32 undef> %a = add nsw <2 x i32> %x, <i32 12, i32 undef>
%3 = tail call { <2 x i32>, <2 x i1> } @llvm.sadd.with.overflow.v2i32(<2 x i32> %2, <2 x i32> <i32 30, i32 30>) %b = tail call { <2 x i32>, <2 x i1> } @llvm.sadd.with.overflow.v2i32(<2 x i32> %a, <2 x i32> <i32 30, i32 30>)
ret { <2 x i32>, <2 x i1> } %3 ret { <2 x i32>, <2 x i1> } %b
} }
define { <2 x i32>, <2 x i1> } @no_fold_splat_not_constant(<2 x i32>, <2 x i32>) { define { <2 x i32>, <2 x i1> } @no_fold_splat_not_constant(<2 x i32> %x, <2 x i32> %y) {
; CHECK-LABEL: @no_fold_splat_not_constant( ; CHECK-LABEL: @no_fold_splat_not_constant(
; CHECK-NEXT: [[TMP3:%.*]] = add nsw <2 x i32> [[TMP0:%.*]], [[TMP1:%.*]] ; CHECK-NEXT: [[A:%.*]] = add nsw <2 x i32> [[X:%.*]], [[Y:%.*]]
; CHECK-NEXT: [[TMP4:%.*]] = tail call { <2 x i32>, <2 x i1> } @llvm.sadd.with.overflow.v2i32(<2 x i32> [[TMP3]], <2 x i32> <i32 30, i32 30>) ; CHECK-NEXT: [[B:%.*]] = tail call { <2 x i32>, <2 x i1> } @llvm.sadd.with.overflow.v2i32(<2 x i32> [[A]], <2 x i32> <i32 30, i32 30>)
; CHECK-NEXT: ret { <2 x i32>, <2 x i1> } [[TMP4]] ; CHECK-NEXT: ret { <2 x i32>, <2 x i1> } [[B]]
; ;
%3 = add nsw <2 x i32> %0, %1 %a = add nsw <2 x i32> %x, %y
%4 = tail call { <2 x i32>, <2 x i1> } @llvm.sadd.with.overflow.v2i32(<2 x i32> %3, <2 x i32> <i32 30, i32 30>) %b = tail call { <2 x i32>, <2 x i1> } @llvm.sadd.with.overflow.v2i32(<2 x i32> %a, <2 x i32> <i32 30, i32 30>)
ret { <2 x i32>, <2 x i1> } %4 ret { <2 x i32>, <2 x i1> } %b
} }
define { i32, i1 } @fold_nuwnsw(i32) { define { i32, i1 } @fold_nuwnsw(i32 %x) {
; CHECK-LABEL: @fold_nuwnsw( ; CHECK-LABEL: @fold_nuwnsw(
; CHECK-NEXT: [[TMP2:%.*]] = call { i32, i1 } @llvm.sadd.with.overflow.i32(i32 [[TMP0:%.*]], i32 42) ; CHECK-NEXT: [[TMP1:%.*]] = call { i32, i1 } @llvm.sadd.with.overflow.i32(i32 [[X:%.*]], i32 42)
; CHECK-NEXT: ret { i32, i1 } [[TMP2]] ; CHECK-NEXT: ret { i32, i1 } [[TMP1]]
; ;
%2 = add nuw nsw i32 %0, 12 %a = add nuw nsw i32 %x, 12
%3 = tail call { i32, i1 } @llvm.sadd.with.overflow.i32(i32 %2, i32 30) %b = tail call { i32, i1 } @llvm.sadd.with.overflow.i32(i32 %a, i32 30)
ret { i32, i1 } %3 ret { i32, i1 } %b
} }
define { i32, i1 } @no_fold_nuw(i32) { define { i32, i1 } @no_fold_nuw(i32 %x) {
; CHECK-LABEL: @no_fold_nuw( ; CHECK-LABEL: @no_fold_nuw(
; CHECK-NEXT: [[TMP2:%.*]] = add nuw i32 [[TMP0:%.*]], 12 ; CHECK-NEXT: [[A:%.*]] = add nuw i32 [[X:%.*]], 12
; CHECK-NEXT: [[TMP3:%.*]] = tail call { i32, i1 } @llvm.sadd.with.overflow.i32(i32 [[TMP2]], i32 30) ; CHECK-NEXT: [[B:%.*]] = tail call { i32, i1 } @llvm.sadd.with.overflow.i32(i32 [[A]], i32 30)
; CHECK-NEXT: ret { i32, i1 } [[TMP3]] ; CHECK-NEXT: ret { i32, i1 } [[B]]
; ;
%2 = add nuw i32 %0, 12 %a = add nuw i32 %x, 12
%3 = tail call { i32, i1 } @llvm.sadd.with.overflow.i32(i32 %2, i32 30) %b = tail call { i32, i1 } @llvm.sadd.with.overflow.i32(i32 %a, i32 30)
ret { i32, i1 } %3 ret { i32, i1 } %b
} }

llvm/test/Transforms/InstCombine/with_overflow.ll

Show First 20 Lines • Show All 462 Lines • ▼ Show 20 Lines
; ;
%a = call { i32, i1 } @llvm.uadd.with.overflow.i32(i32 %x, i32 -1) %a = call { i32, i1 } @llvm.uadd.with.overflow.i32(i32 %x, i32 -1)
%b = extractvalue { i32, i1 } %a, 1 %b = extractvalue { i32, i1 } %a, 1
store i1 %b, i1* %p store i1 %b, i1* %p
%c = extractvalue { i32, i1 } %a, 0 %c = extractvalue { i32, i1 } %a, 0
%d = icmp ult i32 %c, -1 %d = icmp ult i32 %c, -1
ret i1 %d ret i1 %d
} }
define { i32, i1 } @sadd_canonicalize_constant_arg0(i32 %x) nounwind {
; CHECK-LABEL: @sadd_canonicalize_constant_arg0(
; CHECK-NEXT: [[A:%.*]] = call { i32, i1 } @llvm.sadd.with.overflow.i32(i32 [[X:%.*]], i32 42)
; CHECK-NEXT: ret { i32, i1 } [[A]]
;
%a = call { i32, i1 } @llvm.sadd.with.overflow.i32(i32 42, i32 %x)
ret { i32, i1 } %a
}
define { i32, i1 } @uadd_canonicalize_constant_arg0(i32 %x) nounwind {
; CHECK-LABEL: @uadd_canonicalize_constant_arg0(
; CHECK-NEXT: [[A:%.*]] = call { i32, i1 } @llvm.uadd.with.overflow.i32(i32 [[X:%.*]], i32 42)
; CHECK-NEXT: ret { i32, i1 } [[A]]
;
%a = call { i32, i1 } @llvm.uadd.with.overflow.i32(i32 42, i32 %x)
ret { i32, i1 } %a
}
define { i32, i1 } @ssub_no_canonicalize_constant_arg0(i32 %x) nounwind {
; CHECK-LABEL: @ssub_no_canonicalize_constant_arg0(
; CHECK-NEXT: [[A:%.*]] = call { i32, i1 } @llvm.ssub.with.overflow.i32(i32 42, i32 [[X:%.*]])
; CHECK-NEXT: ret { i32, i1 } [[A]]
;
%a = call { i32, i1 } @llvm.ssub.with.overflow.i32(i32 42, i32 %x)
ret { i32, i1 } %a
}
define { i32, i1 } @usub_no_canonicalize_constant_arg0(i32 %x) nounwind {
; CHECK-LABEL: @usub_no_canonicalize_constant_arg0(
; CHECK-NEXT: [[A:%.*]] = call { i32, i1 } @llvm.usub.with.overflow.i32(i32 42, i32 [[X:%.*]])
; CHECK-NEXT: ret { i32, i1 } [[A]]
;
%a = call { i32, i1 } @llvm.usub.with.overflow.i32(i32 42, i32 %x)
ret { i32, i1 } %a
}
define { i32, i1 } @smul_canonicalize_constant_arg0(i32 %x) nounwind {
; CHECK-LABEL: @smul_canonicalize_constant_arg0(
; CHECK-NEXT: [[A:%.*]] = call { i32, i1 } @llvm.smul.with.overflow.i32(i32 [[X:%.*]], i32 42)
; CHECK-NEXT: ret { i32, i1 } [[A]]
;
%a = call { i32, i1 } @llvm.smul.with.overflow.i32(i32 42, i32 %x)
ret { i32, i1 } %a
}
define { i32, i1 } @umul_canonicalize_constant_arg0(i32 %x) nounwind {
; CHECK-LABEL: @umul_canonicalize_constant_arg0(
; CHECK-NEXT: [[A:%.*]] = call { i32, i1 } @llvm.umul.with.overflow.i32(i32 [[X:%.*]], i32 42)
; CHECK-NEXT: ret { i32, i1 } [[A]]
;
%a = call { i32, i1 } @llvm.umul.with.overflow.i32(i32 42, i32 %x)
ret { i32, i1 } %a
}