This is an archive of the discontinued LLVM Phabricator instance.

Implement software breakpoints for arm in Linux platform.
ClosedPublic

Authored by sas on Oct 22 2014, 5:09 PM.

Details

Summary

This change adds the list of software breakpoints for Linux-arm targets. The opcodes used are different from what is specified by ARM because the linux kernel expects something slightly different. The relevant code in the kernel can be found here: https://github.com/torvalds/linux/blob/master/arch/arm/kernel/ptrace.c#L223

Diff Detail

Event Timeline

sas updated this revision to Diff 15287.Oct 22 2014, 5:09 PM
sas retitled this revision from to Implement software breakpoints for arm in Linux platform..
sas updated this object.
sas edited the test plan for this revision. (Show Details)
sas added a reviewer: tfiala.
sas added subscribers: Unknown Object (MLST), jasonmolenda.Oct 22 2014, 5:10 PM

This looks good to me but yeah, we should prob wait for Todd to sign off on it before committing.

jasonmolenda accepted this revision.Oct 27 2014, 8:50 PM
jasonmolenda added a reviewer: jasonmolenda.

I think Todd is a little busy with non-lldb stuff right now. I've reviewed this.

This revision is now accepted and ready to land.Oct 27 2014, 8:50 PM
jasonmolenda closed this revision.Oct 27 2014, 8:54 PM

Landed in r220762.

sas added a comment.Oct 27 2014, 9:02 PM

Thanks Jason.