This is an archive of the discontinued LLVM Phabricator instance.

Change the RegionSet type to a SetVector

Authored by dpeixott on Oct 21 2014, 5:17 PM.



This patch changes the RegionSet type used in ScopDetection from a
std::set to a llvm::SetVector. The reason for the change is to
ensure deterministic output when printing the result of the
analysis. We had a windows buildbot failure for the modified test
because the output was coming in a different order.

Only one test case needed to be modified for this change. We could
use CHECK-DAG directives instead of CHECK in the analysis test cases
because the actual order of scops does not matter, but I think that
change should be done in a separate patch that modifies all the
appliciable tests. I simply modified the test to reflect the
expected deterministic output.

Diff Detail


Event Timeline

dpeixott updated this revision to Diff 15225.Oct 21 2014, 5:17 PM
dpeixott retitled this revision from to Change the RegionSet type to a SetVector.
dpeixott updated this object.
dpeixott added reviewers: grosser, jdoerfert, sebpop.
dpeixott added a subscriber: Unknown Object (MLST).
dpeixott closed this revision.Oct 22 2014, 1:49 PM
dpeixott updated this revision to Diff 15274.

Closed by commit rL220423 (authored by @dpeixott).