[InstCombine] Extend saturating idempotent atomicrmw transform to FP

[reames]

Summary

I'm assuming that the nan propogation logic for InstructonSimplify's handling of fadd and fsub is correct, and applying the same to atomicrmw.

[jfb]

Two nits, LGTM, with @scanon for visibility.

lib/Transforms/InstCombine/InstCombineAtomicRMW.cpp

60 ↗

(On Diff #188940)

Typo "equivalent"

77 ↗

(On Diff #188940)

Remove TODO

llvm/trunk/lib/Transforms/InstCombine/InstCombineAtomicRMW.cpp

switch(RMWI.getOperation()) {
     case AtomicRMWInst::UMax:
       return C->isMinValue(false);
     default:
       return false;
   }
 }
 
 /// Return true if the given instruction always produces a value in memory
-/// equivelent to its value operand.
+/// equivalent to its value operand.
 bool isSaturating(AtomicRMWInst& RMWI) {
+  if (auto CF = dyn_cast<ConstantFP>(RMWI.getValOperand()))
+    switch(RMWI.getOperation()) {
+    case AtomicRMWInst::FAdd:
+    case AtomicRMWInst::FSub:
+      return CF->isNaN();
+    default:
+      return false;
+    };
+
   auto C = dyn_cast<ConstantInt>(RMWI.getValOperand());
   if(!C)
     return false;
 
   switch(RMWI.getOperation()) {
   default:
-    // TODO: fadd, fsub w/Nan
     return false;
   case AtomicRMWInst::Xchg:
     return true;
   case AtomicRMWInst::Or:
     return C->isAllOnesValue();
   case AtomicRMWInst::And:
     return C->isZero();
   case AtomicRMWInst::Min:

llvm/trunk/test/Transforms/InstCombine/atomicrmw.ll

 ; CHECK-NEXT: %res = atomicrmw xchg i8* %addr, i8 127 monotonic
 ; CHECK-NEXT: ret i8 %res
 define i8 @sat_max_smax_char(i8* %addr) {
   %res = atomicrmw max i8* %addr, i8 127 monotonic
   ret i8 %res
 }
 
 ; CHECK-LABEL: sat_fadd_nan
-; CHECK-NEXT: %res = atomicrmw fadd double* %addr, double 0x7FF00000FFFFFFFF release
+; CHECK-NEXT: %res = atomicrmw xchg double* %addr, double 0x7FF00000FFFFFFFF release
 ; CHECK-NEXT: ret double %res
 define double @sat_fadd_nan(double* %addr) {
   %res = atomicrmw fadd double* %addr, double 0x7FF00000FFFFFFFF release
   ret double %res
 }
 
 ; CHECK-LABEL: sat_fsub_nan
-; CHECK-NEXT: %res = atomicrmw fsub double* %addr, double 0x7FF00000FFFFFFFF release
+; CHECK-NEXT: %res = atomicrmw xchg double* %addr, double 0x7FF00000FFFFFFFF release
 ; CHECK-NEXT: ret double %res
 define double @sat_fsub_nan(double* %addr) {
   %res = atomicrmw fsub double* %addr, double 0x7FF00000FFFFFFFF release
   ret double %res
 }
 
 ; CHECK-LABEL: sat_fsub_nan_unused
-; CHECK-NEXT: atomicrmw fsub double* %addr, double 0x7FF00000FFFFFFFF monotonic
+; CHECK-NEXT: store atomic double 0x7FF00000FFFFFFFF, double* %addr monotonic, align 8
 ; CHECK-NEXT: ret void
 define void @sat_fsub_nan_unused(double* %addr) {
   atomicrmw fsub double* %addr, double 0x7FF00000FFFFFFFF monotonic
   ret void
 }
 
 ; CHECK-LABEL: xchg_unused_monotonic
 ; CHECK-NEXT: store atomic i32 0, i32* %addr monotonic, align 4