Page MenuHomePhabricator

Remove extraneous space in MSVC-style diagnostic output
ClosedPublic

Authored by hans on Feb 19 2019, 12:33 AM.

Details

Summary

There was an extra space between the file location and the diagnostic message:

/tmp/a.c(1,12):  warning: unused parameter 'unused'

the tests didn't catch this due to FileCheck not running in --strict-whitespace mode.

Diff Detail

Repository
rC Clang

Event Timeline

hans created this revision.Feb 19 2019, 12:33 AM
hans updated this revision to Diff 187320.Feb 19 2019, 12:36 AM

Output a char instead of a one-character string.

thakis accepted this revision.Feb 19 2019, 6:54 AM

whaaaat

This revision is now accepted and ready to land.Feb 19 2019, 6:54 AM
This revision was automatically updated to reflect the committed changes.
Herald added a project: Restricted Project. · View Herald TranscriptFeb 19 2019, 8:59 AM