Page MenuHomePhabricator

[SystemZ] Make sure VEXTEND and VROUND nodes are not emitted without vector support.
ClosedPublic

Authored by jonpa on Feb 14 2019, 9:22 AM.

Details

Reviewers
uweigand
Summary

Building the testsuite with the generic target (z10) revealed missing checks for vector support in combineFP_ROUND() and combineFP_EXTEND().

Diff Detail

Event Timeline

jonpa created this revision.Feb 14 2019, 9:22 AM
uweigand accepted this revision.Feb 14 2019, 9:35 AM

Ah, good catch! LGTM.

This revision is now accepted and ready to land.Feb 14 2019, 9:35 AM
jonpa closed this revision.Feb 14 2019, 10:01 AM

r354039.

This failed to pass the machine verifier in http://green.lab.llvm.org/green/job/clang-stage1-cmake-RA-expensive/13579/.

It can be reproduced by adding -verify-machineinstrs to the llc invocation in test/CodeGen/SystemZ/fp-conv-18.mir.

I reverted this in rL354096.

Thanks!