Page MenuHomePhabricator

[gn build] Separate debug and optimization settings

Authored by dmajor on Feb 11 2019, 2:17 PM.



This patch adds an is_optimized variable, orthogonal to is_debug, to allow for a gn analogue to RelWithDebInfo builds.

As part of this we'll want to explicitly enable GC+ICF, for the sake of is_debug && is_optimized builds. The flags normally default to true except that if you pass /DEBUG they default to false.

Diff Detail

Event Timeline

dmajor created this revision.Feb 11 2019, 2:17 PM
Herald added a project: Restricted Project. · View Herald TranscriptFeb 11 2019, 2:17 PM
thakis accepted this revision.Feb 12 2019, 7:07 AM

This is fine for now, but I think eventually we'll want to either make this per-toolchain or put it in a config, for e.g. optimize-tablegen-in-otherwise-non-opt builds.

This revision is now accepted and ready to land.Feb 12 2019, 7:07 AM
This revision was automatically updated to reflect the committed changes.