Page MenuHomePhabricator

[HotColdSplit] With PGO add profile entry metadata to split cold function
ClosedPublic

Authored by tejohnson on Thu, Feb 7, 9:14 AM.

Details

Summary

When compiling with profile data, ensure the split cold function gets
cold function_entry_count metadata (just use 0 since it should be cold).
Otherwise with function sections it will not be placed in the unlikely
text section with other cold code.

Diff Detail

Repository
rL LLVM

Event Timeline

tejohnson created this revision.Thu, Feb 7, 9:14 AM
Herald added a project: Restricted Project. · View Herald TranscriptThu, Feb 7, 9:14 AM
vsk accepted this revision.Thu, Feb 7, 9:48 AM

Thanks, lgtm.

This revision is now accepted and ready to land.Thu, Feb 7, 9:48 AM
This revision was automatically updated to reflect the committed changes.