Page MenuHomePhabricator

ArgumentPromotion should copy all metadata to new Function
ClosedPublic

Authored by tejohnson on Feb 6 2019, 2:01 PM.

Details

Summary

ArgumentPromotion had code to specifically move the dbg metadata over to
the new function, but other metadata such as the function_entry_count
!prof metadata was not. Replace code that moved dbg metadata with a call
to copyMetadata. The old metadata is automatically removed when the old
Function is removed.

Diff Detail

Repository
rL LLVM

Event Timeline

tejohnson created this revision.Feb 6 2019, 2:01 PM
Herald added a project: Restricted Project. · View Herald TranscriptFeb 6 2019, 2:01 PM
davidxl accepted this revision.Feb 8 2019, 8:56 AM

lgtm

This revision is now accepted and ready to land.Feb 8 2019, 8:56 AM
This revision was automatically updated to reflect the committed changes.