Page MenuHomePhabricator

[SamplePGO] More pipeline changes when flattened profile used in ThinLTO postlink
ClosedPublic

Authored by tejohnson on Feb 4 2019, 11:50 AM.

Details

Summary

Follow on to D54819/r351476.

We also don't need to perform extra InstCombine pass when we aren't
loading the sample profile in the ThinLTO backend because we have a
flattened sample profile.

Additionally, for consistency and clarity, when we aren't reloading the
sample profile, perform ICP in the same location as non-sample PGO
backends. To this end I have moved the ICP invocation for non-SamplePGO
ThinLTO down into buildModuleSimplificationPipeline (partly addresses
the FIXME where we were previously setting this up).

Diff Detail

Repository
rL LLVM

Event Timeline

tejohnson created this revision.Feb 4 2019, 11:50 AM
Herald added a project: Restricted Project. · View Herald TranscriptFeb 4 2019, 11:50 AM
wmi accepted this revision.Feb 4 2019, 4:16 PM

LGTM.

This revision is now accepted and ready to land.Feb 4 2019, 4:16 PM
This revision was automatically updated to reflect the committed changes.