Page MenuHomePhabricator

[libcxx] Tests cleanup: use UNSUPPORTED instead of TEST_STD_VER.
ClosedPublic

Authored by amakc11 on Feb 4 2019, 11:49 AM.

Details

Reviewers
EricWF
ldionne
Summary

Some older tests use, for example, the following template:

#if TEST_STD_VER > 11
<do something useful testing>
#else
int main() {}
#endif

It yields building and running an "empty" test if the condition on TEST_STD_VER evaluates to false. This patch replaces this template with appropriate UNSUPPORTED directive which prevents spending time on building and running such tests in unsupported environment.

Diff Detail

Event Timeline

amakc11 created this revision.Feb 4 2019, 11:49 AM
ldionne accepted this revision.Feb 4 2019, 12:45 PM

I prefer this approach because it allows us to see which tests are supported/unsupported under a given standard. The same holds for configurations like host system, deployment target on OSX & al. I like this change.

This revision is now accepted and ready to land.Feb 4 2019, 12:45 PM

Can you please rebase on top of the latest master? https://reviews.llvm.org/D57624 makes it not apply cleanly :-(

Oops, seems like a "commit race" happened. :-)

amakc11 updated this revision to Diff 185298.Feb 5 2019, 6:36 AM

Patch is rebased as requested.

ldionne accepted this revision.Feb 5 2019, 11:49 AM
ldionne closed this revision.

Thanks for the patch! Committed as r353206.