This is an archive of the discontinued LLVM Phabricator instance.

Differential D57679

[LLD] [MinGW] Hook up the --no-insert-timestamp option
ClosedPublic

Authored by mstorsjo on Feb 4 2019, 4:17 AM.

Details

Reviewers
ruiu
rnk
Commits
rG537a718fcbbc: [MinGW] Hook up the --no-insert-timestamp option
rLLD353145: [MinGW] Hook up the --no-insert-timestamp option
rL353145: [MinGW] Hook up the --no-insert-timestamp option
Summary

This fixes PR40582.

Patch by Georg Koppen!

Diff Detail

Repository
rL LLVM

Event Timeline

mstorsjo created this revision.Feb 4 2019, 4:17 AM
Herald added a project: Restricted Project. · View Herald TranscriptFeb 4 2019, 4:17 AM
rnk accepted this revision.Feb 4 2019, 1:49 PM

lgtm

This revision is now accepted and ready to land.Feb 4 2019, 1:49 PM
Closed by commit rL353145: [MinGW] Hook up the --no-insert-timestamp option (authored by mstorsjo). · Explain WhyFeb 5 2019, 12:16 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents

PathSize
lld/
trunk/
MinGW/
3 lines
2 lines
test/
MinGW/
3 lines

Diff 185246

lld/trunk/MinGW/Driver.cpp

Show First 20 Lines • Show All 181 Lines • ▼ Show 20 Lines if (Args.hasArg(OPT_large_address_aware))
Add("-largeaddressaware"); Add("-largeaddressaware");
if (Args.hasArg(OPT_kill_at)) if (Args.hasArg(OPT_kill_at))
Add("-kill-at"); Add("-kill-at");
if (Args.getLastArgValue(OPT_m) != "thumb2pe" && if (Args.getLastArgValue(OPT_m) != "thumb2pe" &&
Args.getLastArgValue(OPT_m) != "arm64pe" && !Args.hasArg(OPT_dynamicbase)) Args.getLastArgValue(OPT_m) != "arm64pe" && !Args.hasArg(OPT_dynamicbase))
Add("-dynamicbase:no"); Add("-dynamicbase:no");
if (Args.hasArg(OPT_no_insert_timestamp))
Add("-timestamp:0");
if (Args.hasFlag(OPT_gc_sections, OPT_no_gc_sections, false)) if (Args.hasFlag(OPT_gc_sections, OPT_no_gc_sections, false))
Add("-opt:ref"); Add("-opt:ref");
else else
Add("-opt:noref"); Add("-opt:noref");
if (auto *A = Args.getLastArg(OPT_icf)) { if (auto *A = Args.getLastArg(OPT_icf)) {
StringRef S = A->getValue(); StringRef S = A->getValue();
if (S == "all") if (S == "all")
▲ Show 20 Lines • Show All 83 Lines • Show Last 20 Lines

lld/trunk/MinGW/Options.td

Show All 16 Lines
def icf: J<"icf=">, HelpText<"Identical code folding">; def icf: J<"icf=">, HelpText<"Identical code folding">;
def image_base: S<"image-base">, HelpText<"Base address of the program">; def image_base: S<"image-base">, HelpText<"Base address of the program">;
def kill_at: F<"kill-at">, HelpText<"Remove @n from exported symbols">; def kill_at: F<"kill-at">, HelpText<"Remove @n from exported symbols">;
def l: JoinedOrSeparate<["-"], "l">, MetaVarName<"<libName>">, def l: JoinedOrSeparate<["-"], "l">, MetaVarName<"<libName>">,
HelpText<"Root name of library to use">; HelpText<"Root name of library to use">;
def m: JoinedOrSeparate<["-"], "m">, HelpText<"Set target emulation">; def m: JoinedOrSeparate<["-"], "m">, HelpText<"Set target emulation">;
def map: S<"Map">, HelpText<"Output a linker map">; def map: S<"Map">, HelpText<"Output a linker map">;
def map_eq: J<"Map=">, Alias<map>; def map_eq: J<"Map=">, Alias<map>;
def no_insert_timestamp: F<"no-insert-timestamp">,
HelpText<"Don't include PE header timestamp">;
def no_whole_archive: F<"no-whole-archive">, def no_whole_archive: F<"no-whole-archive">,
HelpText<"No longer include all object files for following archives">; HelpText<"No longer include all object files for following archives">;
def large_address_aware: Flag<["--"], "large-address-aware">, def large_address_aware: Flag<["--"], "large-address-aware">,
HelpText<"Enable large addresses">; HelpText<"Enable large addresses">;
def no_gc_sections: F<"no-gc-sections">, HelpText<"Don't remove unused sections">; def no_gc_sections: F<"no-gc-sections">, HelpText<"Don't remove unused sections">;
def o: JoinedOrSeparate<["-"], "o">, MetaVarName<"<path>">, def o: JoinedOrSeparate<["-"], "o">, MetaVarName<"<path>">,
HelpText<"Path to file to write output">; HelpText<"Path to file to write output">;
def out_implib: Separate<["--"], "out-implib">, HelpText<"Import library name">; def out_implib: Separate<["--"], "out-implib">, HelpText<"Import library name">;
▲ Show 20 Lines • Show All 52 Lines • Show Last 20 Lines

lld/trunk/test/MinGW/driver.test

Show First 20 Lines • Show All 145 Lines • ▼ Show 20 Lines
RUN: ld.lld -### foo.o -m i386pep --Map=bar.map | FileCheck -check-prefix=MAP %s RUN: ld.lld -### foo.o -m i386pep --Map=bar.map | FileCheck -check-prefix=MAP %s
MAP: -lldmap:bar.map MAP: -lldmap:bar.map
RUN: ld.lld -### foo.o -m i386pe -require-defined _foo --require-defined _bar -require-defined=_baz --require-defined=_foo2 | FileCheck -check-prefix=REQUIRE-DEFINED %s RUN: ld.lld -### foo.o -m i386pe -require-defined _foo --require-defined _bar -require-defined=_baz --require-defined=_foo2 | FileCheck -check-prefix=REQUIRE-DEFINED %s
REQUIRE-DEFINED: -include:_foo -include:_bar -include:_baz -include:_foo2 REQUIRE-DEFINED: -include:_foo -include:_bar -include:_baz -include:_foo2
RUN: ld.lld -### -m i386pep foo.o -Llibpath | FileCheck -check-prefix LIBPATH %s RUN: ld.lld -### -m i386pep foo.o -Llibpath | FileCheck -check-prefix LIBPATH %s
LIBPATH: -libpath:libpath LIBPATH: -libpath:libpath
RUN: ld.lld -### -m i386pep foo.o --no-insert-timestamp | FileCheck -check-prefix NOTIMESTAMP %s
NOTIMESTAMP: -timestamp:0