This is an archive of the discontinued LLVM Phabricator instance.

Fix format string in bindings/go/llvm/ir_test.go (PR40561)
ClosedPublic

Authored by hans on Feb 4 2019, 1:25 AM.

Details

Summary

The test started failing for me recently. I don't see any changes around this code, so maybe it's my local go version that changed or something.

The error seems real to me: we're trying to print an Attribute with %d. The test talks about "attribute masks" I'm not sure what that refers to, but I suppose we could print the raw pointer value, since that's what the test seems to be comparing.

Diff Detail

Event Timeline

hans created this revision.Feb 4 2019, 1:25 AM
pcc accepted this revision.Feb 4 2019, 11:39 AM

LGTM

This revision is now accepted and ready to land.Feb 4 2019, 11:39 AM
This revision was automatically updated to reflect the committed changes.
Herald added a project: Restricted Project. · View Herald TranscriptFeb 5 2019, 3:01 AM