This is an archive of the discontinued LLVM Phabricator instance.

Differential D57638

[pstl] Fix missing parallel policy guards
ClosedPublic

Authored by jerryct on Feb 2 2019, 1:09 AM.

Details

Reviewers
ldionne
rodgert
MikeDvorskiy
Commits
rPSTL355161: [pstl] Fix missing parallel policy guards
rG6aad7945d7ba: [pstl] Fix missing parallel policy guards
rL355161: [pstl] Fix missing parallel policy guards
Summary

Address coments from https://reviews.llvm.org/D56139

Diff Detail

Repository
rL LLVM

Event Timeline

jerryct created this revision.Feb 2 2019, 1:09 AM
Herald added a subscriber: libcxx-commits. · View Herald TranscriptFeb 2 2019, 1:10 AM
MikeDvorskiy accepted this revision.Feb 19 2019, 3:12 AM
This revision is now accepted and ready to land.Feb 19 2019, 3:12 AM
Closed by commit rL355161: [pstl] Fix missing parallel policy guards (authored by ldionne). · Explain WhyFeb 28 2019, 5:27 PM
This revision was automatically updated to reflect the committed changes.
Herald added a project: Restricted Project. · View Herald TranscriptFeb 28 2019, 5:27 PM
Herald added a subscriber: llvm-commits. · View Herald Transcript

Revision Contents

PathSize
pstl/
trunk/
include/
pstl/
internal/
4 lines

Diff 188818

pstl/trunk/include/pstl/internal/algorithm_impl.h

Show First 20 Lines • Show All 171 Lines • ▼ Show 20 Lines
template <class _ExecutionPolicy, class _ForwardIterator, class _Size, class _Function, class _IsVector> template <class _ExecutionPolicy, class _ForwardIterator, class _Size, class _Function, class _IsVector>
_ForwardIterator _ForwardIterator
pattern_walk1_n(_ExecutionPolicy&&, _ForwardIterator __first, _Size __n, _Function __f, _IsVector __is_vector, pattern_walk1_n(_ExecutionPolicy&&, _ForwardIterator __first, _Size __n, _Function __f, _IsVector __is_vector,
/*is_parallel=*/std::false_type) noexcept /*is_parallel=*/std::false_type) noexcept
{ {
return internal::brick_walk1_n(__first, __n, __f, __is_vector); return internal::brick_walk1_n(__first, __n, __f, __is_vector);
} }
#if __PSTL_USE_PAR_POLICIES
template <class _ExecutionPolicy, class _RandomAccessIterator, class _Size, class _Function, class _IsVector> template <class _ExecutionPolicy, class _RandomAccessIterator, class _Size, class _Function, class _IsVector>
_RandomAccessIterator _RandomAccessIterator
pattern_walk1_n(_ExecutionPolicy&& __exec, _RandomAccessIterator __first, _Size __n, _Function __f, pattern_walk1_n(_ExecutionPolicy&& __exec, _RandomAccessIterator __first, _Size __n, _Function __f,
_IsVector __is_vector, _IsVector __is_vector,
/*is_parallel=*/std::true_type) /*is_parallel=*/std::true_type)
{ {
internal::pattern_walk1(std::forward<_ExecutionPolicy>(__exec), __first, __first + __n, __f, __is_vector, internal::pattern_walk1(std::forward<_ExecutionPolicy>(__exec), __first, __first + __n, __f, __is_vector,
std::true_type()); std::true_type());
return __first + __n; return __first + __n;
} }
#endif
template <class _ExecutionPolicy, class _ForwardIterator, class _Size, class _Brick> template <class _ExecutionPolicy, class _ForwardIterator, class _Size, class _Brick>
_ForwardIterator _ForwardIterator
pattern_walk_brick_n(_ExecutionPolicy&&, _ForwardIterator __first, _Size __n, _Brick __brick, pattern_walk_brick_n(_ExecutionPolicy&&, _ForwardIterator __first, _Size __n, _Brick __brick,
/*is_parallel=*/std::false_type) noexcept /*is_parallel=*/std::false_type) noexcept
{ {
return __brick(__first, __n); return __brick(__first, __n);
} }
▲ Show 20 Lines • Show All 2,296 Lines • ▼ Show 20 Lines
template <class _ExecutionPolicy, class _OutputIterator, class _Size, class _Generator, class _IsVector> template <class _ExecutionPolicy, class _OutputIterator, class _Size, class _Generator, class _IsVector>
_OutputIterator _OutputIterator
pattern_generate_n(_ExecutionPolicy&&, _OutputIterator __first, _Size __count, _Generator __g, pattern_generate_n(_ExecutionPolicy&&, _OutputIterator __first, _Size __count, _Generator __g,
/*is_parallel=*/std::false_type, _IsVector __is_vector) noexcept /*is_parallel=*/std::false_type, _IsVector __is_vector) noexcept
{ {
return internal::brick_generate_n(__first, __count, __g, __is_vector); return internal::brick_generate_n(__first, __count, __g, __is_vector);
} }
#if __PSTL_USE_PAR_POLICIES
template <class _ExecutionPolicy, class _OutputIterator, class _Size, class _Generator, class _IsVector> template <class _ExecutionPolicy, class _OutputIterator, class _Size, class _Generator, class _IsVector>
_OutputIterator _OutputIterator
pattern_generate_n(_ExecutionPolicy&& __exec, _OutputIterator __first, _Size __count, _Generator __g, pattern_generate_n(_ExecutionPolicy&& __exec, _OutputIterator __first, _Size __count, _Generator __g,
/*is_parallel=*/std::true_type, _IsVector __is_vector) /*is_parallel=*/std::true_type, _IsVector __is_vector)
{ {
static_assert(internal::is_random_access_iterator<_OutputIterator>::value, static_assert(internal::is_random_access_iterator<_OutputIterator>::value,
"Pattern-brick error. Should be a random access iterator."); "Pattern-brick error. Should be a random access iterator.");
return internal::pattern_generate(std::forward<_ExecutionPolicy>(__exec), __first, __first + __count, __g, return internal::pattern_generate(std::forward<_ExecutionPolicy>(__exec), __first, __first + __count, __g,
std::true_type(), __is_vector); std::true_type(), __is_vector);
} }
#endif
//------------------------------------------------------------------------ //------------------------------------------------------------------------
// remove // remove
//------------------------------------------------------------------------ //------------------------------------------------------------------------
template <class _ForwardIterator, class _UnaryPredicate> template <class _ForwardIterator, class _UnaryPredicate>
_ForwardIterator _ForwardIterator
brick_remove_if(_ForwardIterator __first, _ForwardIterator __last, _UnaryPredicate __pred, brick_remove_if(_ForwardIterator __first, _ForwardIterator __last, _UnaryPredicate __pred,
▲ Show 20 Lines • Show All 1,133 Lines • Show Last 20 Lines