Page MenuHomePhabricator

gn build: Windows: write PDBs when is_debug
ClosedPublic

Authored by dmajor on Feb 1 2019, 12:33 PM.

Details

Summary

Without /DEBUG, the /Zi doesn't on its own create PDB files.

And since ninja runs multiple compilations in parallel, we need /FS to prevent contention on PDBs.

Diff Detail

Repository
rL LLVM

Event Timeline

dmajor created this revision.Feb 1 2019, 12:33 PM
thakis accepted this revision.Feb 1 2019, 4:45 PM
This revision is now accepted and ready to land.Feb 1 2019, 4:45 PM
This revision was automatically updated to reflect the committed changes.
Herald added a project: Restricted Project. · View Herald TranscriptFeb 4 2019, 1:13 PM