This is an archive of the discontinued LLVM Phabricator instance.

[llvm-symbolizer][test] Rename and tweak tests using llvm-symbolizer
ClosedPublic

Authored by jhenderson on Jan 31 2019, 9:11 AM.

Details

Summary

There are a few tests called llvm-symbolizer* in the DebugInfo test area. These really are testing either the DebugInfo or Symbolizer library, rather than the llvm-symbolizer tool itself, so this patch renames them to be clearer that they aren't explicitly tests for llvm-symbolizer (such tests belong in test/tools/llvm-symbolizer).

This patch also reinstates the copying of a DWO file, removed previously in rL352752. The test needs this so that it could possibly fail.

Finally, some of the tests have been simplified slightly by removing unnecessary switches and/or unused check-prefixes.

Diff Detail

Repository
rL LLVM

Event Timeline

jhenderson created this revision.Jan 31 2019, 9:11 AM
dblaikie accepted this revision.Jan 31 2019, 3:35 PM

Looks good, thanks!

This revision is now accepted and ready to land.Jan 31 2019, 3:35 PM
Herald added a project: Restricted Project. · View Herald TranscriptJan 31 2019, 3:35 PM
This revision was automatically updated to reflect the committed changes.
test/DebugInfo/llvm-symbolizer-split-dwarf-no-skel-address.test