This is an archive of the discontinued LLVM Phabricator instance.

Differential D57518

[llvm-symbolizer][test] Rename and tweak tests using llvm-symbolizer
ClosedPublic

Authored by jhenderson on Jan 31 2019, 9:11 AM.

Details

Reviewers
dblaikie
Commits
rG563a29d449de: [llvm-symbolizer][test] Rename and tweak tests using llvm-symbolizer
rL352847: [llvm-symbolizer][test] Rename and tweak tests using llvm-symbolizer
Summary

There are a few tests called llvm-symbolizer* in the DebugInfo test area. These really are testing either the DebugInfo or Symbolizer library, rather than the llvm-symbolizer tool itself, so this patch renames them to be clearer that they aren't explicitly tests for llvm-symbolizer (such tests belong in test/tools/llvm-symbolizer).

This patch also reinstates the copying of a DWO file, removed previously in rL352752. The test needs this so that it could possibly fail.

Finally, some of the tests have been simplified slightly by removing unnecessary switches and/or unused check-prefixes.

Diff Detail

Repository
rL LLVM

Event Timeline

jhenderson created this revision.Jan 31 2019, 9:11 AM
dblaikie accepted this revision.Jan 31 2019, 3:35 PM

Looks good, thanks!

This revision is now accepted and ready to land.Jan 31 2019, 3:35 PM
Herald added a project: Restricted Project. · View Herald TranscriptJan 31 2019, 3:35 PM
Closed by commit rL352847: [llvm-symbolizer][test] Rename and tweak tests using llvm-symbolizer (authored by jhenderson). · Explain WhyFeb 1 2019, 2:24 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents

Diff 184520

test/DebugInfo/llvm-symbolizer-split-dwarf-empty.test

RUN: rm -rf %t && mkdir -p %t
RUN: cd %t
RUN: cp %p/Inputs/split-dwarf-empty.dwo %t
RUN: echo "%p/Inputs/split-dwarf-empty.o 0xdeadbeef" > %t.input
RUN: llvm-symbolizer --functions=linkage --inlining --demangle=false \
RUN: --default-arch=i386 < %t.input | FileCheck %s
CHECK: ??
CHECK: ??:0:0

test/DebugInfo/llvm-symbolizer-split-dwarf-no-skel-address.test

RUN: llvm-symbolizer --functions=linkage --inlining --demangle=false \
RUN: --default-arch=i386 --obj=%p/Inputs/split-dwarf-no-skel-address.o 0x4 | FileCheck %s
Built from the following source:
void f1();
__attribute__((always_inline)) inline void f2() { f1(); }
void f3() { f2(); }
Compiled to assembly with clang, modified the skeleton CU to remove the
high/low pc (& update the CU length field and abbrev to match) & then
compile/objcopy to make the .o and .dwo.
Ensure that the f2 inlined frame is not included - it's inefficient to have to
go and load all the debug info and search for the address ranges, so assume
that a lack of ranges on the CU means the CU covers no addresses.
CHECK-NOT: _Z2f2v

test/DebugInfo/llvm-symbolizer-tu.test

RUN: llvm-symbolizer --obj=%p/Inputs/llvm-symbolizer-tu.elf-x86-64 0x0 | FileCheck %s
Built from the following source:
...
CHECK: b.cpp:3:0

test/DebugInfo/llvm-symbolizer-zlib.test

REQUIRES: zlib
RUN: llvm-symbolizer --obj=%p/Inputs/dwarfdump-test-zlib.elf-x86-64 0x4005e9 | FileCheck %s
RUN: llvm-symbolizer --obj=%p/Inputs/dwarfdump-test-zlibgnu.elf-x86-64 0x4005e9 | FileCheck %s
CHECK: main
CHECK-NEXT: /tmp/dbginfo{{[/\\]}}dwarfdump-test-zlib.cc:16

test/DebugInfo/llvm-symbolizer.test

RUN: echo "%p/Inputs/dwarfdump-test.elf-x86-64 0x40113f" > %t.input
RUN: echo "%p/Inputs/dwarfdump-test.elf-x86-64 0x401020" >> %t.input
RUN: echo "%p/Inputs/dwarfdump-test.elf-x86-64 0x40110e" >> %t.input
RUN: echo "%p/Inputs/dwarfdump-test.elf-x86-64 0x401160" >> %t.input
RUN: echo "%p/Inputs/dwarfdump-test2.elf-x86-64 0x4004e8" >> %t.input
RUN: echo "%p/Inputs/dwarfdump-test2.elf-x86-64 0x4004f4" >> %t.input
RUN: echo "%p/Inputs/dwarfdump-test4.elf-x86-64 0x62c" >> %t.input
RUN: llvm-symbolizer --functions=linkage --inlining --demangle=false \
RUN: < %t.input | FileCheck --check-prefix=CHECK --check-prefix=SPLIT --check-prefix=DWO %s
CHECK: main
CHECK-NEXT: /tmp/dbginfo{{[/\\]}}dwarfdump-test.cc:16
CHECK: _start
CHECK: _Z1fii
CHECK-NEXT: /tmp/dbginfo{{[/\\]}}dwarfdump-test.cc:11
CHECK: DummyClass
CHECK-NEXT: /tmp/dbginfo{{[/\\]}}dwarfdump-test.cc:4
CHECK: a
CHECK-NEXT: /tmp/dbginfo{{[/\\]}}dwarfdump-test2-helper.cc:2
CHECK: main
CHECK-NEXT: /tmp/dbginfo{{[/\\]}}dwarfdump-test2-main.cc:4
CHECK: _Z1cv
CHECK-NEXT: /tmp/dbginfo{{[/\\]}}dwarfdump-test4-part1.cc:2

test/DebugInfo/symbolize-split-dwarf-empty.test

cd and copy the DWO into the same directory so that it can be found by the
symbolizer.
RUN: rm -rf %t && mkdir -p %t RUN: rm -rf %t && mkdir -p %t
RUN: cd %t RUN: cd %t
RUN: cp %p/Inputs/split-dwarf-empty.dwo %t RUN: cp %p/Inputs/split-dwarf-empty.dwo %t
RUN: echo "%p/Inputs/split-dwarf-empty.o 0xdeadbeef" > %t.input RUN: llvm-symbolizer --inlining --obj=%p/Inputs/split-dwarf-empty.o 0xdeadbeef | FileCheck %s
RUN: llvm-symbolizer --functions=linkage --inlining --demangle=false \
RUN: --default-arch=i386 < %t.input | FileCheck %s
CHECK: ?? CHECK: ??
CHECK: ??:0:0 CHECK: ??:0:0

test/DebugInfo/symbolize-split-dwarf-no-skel-address.test

RUN: llvm-symbolizer --functions=linkage --inlining --demangle=false \ Copy the DWO and then cd into the output directory, so that the symbolizer would
RUN: --default-arch=i386 --obj=%p/Inputs/split-dwarf-no-skel-address.o 0x4 | FileCheck %s find the DWO if it attempted to.
RUN: rm -rf %t && mkdir -p %t
RUN: cd %t
RUN: cp %p/Inputs/split-dwarf-no-skel-address.dwo %t
RUN: llvm-symbolizer --inlining --no-demangle \
RUN: --obj=%p/Inputs/split-dwarf-no-skel-address.o 0x4 | FileCheck %s
Built from the following source: Built from the following source:
void f1(); void f1();
__attribute__((always_inline)) inline void f2() { f1(); } __attribute__((always_inline)) inline void f2() { f1(); }
void f3() { f2(); } void f3() { f2(); }
Compiled to assembly with clang, modified the skeleton CU to remove the Compiled to assembly with clang, modified the skeleton CU to remove the
high/low pc (& update the CU length field and abbrev to match) & then high/low pc (& update the CU length field and abbrev to match) & then
compile/objcopy to make the .o and .dwo. compile/objcopy to make the .o and .dwo.
Ensure that the f2 inlined frame is not included - it's inefficient to have to Ensure that the f2 inlined frame is not included - it's inefficient to have to
go and load all the debug info and search for the address ranges, so assume go and load all the debug info and search for the address ranges, so assume
that a lack of ranges on the CU means the CU covers no addresses. that a lack of ranges on the CU means the CU covers no addresses.
CHECK-NOT: _Z2f2v CHECK-NOT: _Z2f2v

test/DebugInfo/symbolize-tu.test

The contents of this file were not changed.

test/DebugInfo/symbolize-zlib.test

The contents of this file were not changed.

test/DebugInfo/symbolize.test

RUN: echo "%p/Inputs/dwarfdump-test.elf-x86-64 0x40113f" > %t.input RUN: echo "%p/Inputs/dwarfdump-test.elf-x86-64 0x40113f" > %t.input
RUN: echo "%p/Inputs/dwarfdump-test.elf-x86-64 0x401020" >> %t.input RUN: echo "%p/Inputs/dwarfdump-test.elf-x86-64 0x401020" >> %t.input
RUN: echo "%p/Inputs/dwarfdump-test.elf-x86-64 0x40110e" >> %t.input RUN: echo "%p/Inputs/dwarfdump-test.elf-x86-64 0x40110e" >> %t.input
RUN: echo "%p/Inputs/dwarfdump-test.elf-x86-64 0x401160" >> %t.input RUN: echo "%p/Inputs/dwarfdump-test.elf-x86-64 0x401160" >> %t.input
RUN: echo "%p/Inputs/dwarfdump-test2.elf-x86-64 0x4004e8" >> %t.input RUN: echo "%p/Inputs/dwarfdump-test2.elf-x86-64 0x4004e8" >> %t.input
RUN: echo "%p/Inputs/dwarfdump-test2.elf-x86-64 0x4004f4" >> %t.input RUN: echo "%p/Inputs/dwarfdump-test2.elf-x86-64 0x4004f4" >> %t.input
RUN: echo "%p/Inputs/dwarfdump-test4.elf-x86-64 0x62c" >> %t.input RUN: echo "%p/Inputs/dwarfdump-test4.elf-x86-64 0x62c" >> %t.input
RUN: llvm-symbolizer --functions=linkage --inlining --demangle=false \ RUN: llvm-symbolizer < %t.input | FileCheck %s
RUN: < %t.input | FileCheck --check-prefix=CHECK --check-prefix=SPLIT --check-prefix=DWO %s
CHECK: main CHECK: main
CHECK-NEXT: /tmp/dbginfo{{[/\\]}}dwarfdump-test.cc:16 CHECK-NEXT: /tmp/dbginfo{{[/\\]}}dwarfdump-test.cc:16
CHECK: _start CHECK: _start
CHECK: _Z1fii CHECK: f(int, int)
CHECK-NEXT: /tmp/dbginfo{{[/\\]}}dwarfdump-test.cc:11 CHECK-NEXT: /tmp/dbginfo{{[/\\]}}dwarfdump-test.cc:11
CHECK: DummyClass CHECK: DummyClass
CHECK-NEXT: /tmp/dbginfo{{[/\\]}}dwarfdump-test.cc:4 CHECK-NEXT: /tmp/dbginfo{{[/\\]}}dwarfdump-test.cc:4
CHECK: a CHECK: a
CHECK-NEXT: /tmp/dbginfo{{[/\\]}}dwarfdump-test2-helper.cc:2 CHECK-NEXT: /tmp/dbginfo{{[/\\]}}dwarfdump-test2-helper.cc:2
CHECK: main CHECK: main
CHECK-NEXT: /tmp/dbginfo{{[/\\]}}dwarfdump-test2-main.cc:4 CHECK-NEXT: /tmp/dbginfo{{[/\\]}}dwarfdump-test2-main.cc:4
CHECK: _Z1cv CHECK: c()
CHECK-NEXT: /tmp/dbginfo{{[/\\]}}dwarfdump-test4-part1.cc:2 CHECK-NEXT: /tmp/dbginfo{{[/\\]}}dwarfdump-test4-part1.cc:2
test/DebugInfo/llvm-symbolizer-split-dwarf-no-skel-address.test