Page MenuHomePhabricator

Add a couple more paths where to look for just-build Clang
AbandonedPublic

Authored by kubamracek on Oct 10 2014, 8:19 PM.

Details

Reviewers
None
Summary

Some LLDB build scripts seem to put the built Clang into different paths, let's add a couple more paths where to look for Clang. Currently used only by LLDB's ASan tests.

Diff Detail

Event Timeline

kubamracek updated this revision to Diff 14765.Oct 10 2014, 8:19 PM
kubamracek retitled this revision from to Add a couple more paths where to look for just-build Clang.
kubamracek updated this object.
kubamracek edited the test plan for this revision. (Show Details)
kubamracek added subscribers: Unknown Object (MLST), jasonmolenda.

Are you using the CMake build? Even this will fail if you have multiple
clangs and you want it to choose a specific one. I would suggest setting
the LLDB_TEST_COMPILER CMake variable.

This patch looks fine.

While I agree this patch doesn't break anything, it's also not a complete fix. It would be nice to have a more complete fix, similar to what Kuba suggested with the @requiresAsan conditional.

kubamracek abandoned this revision.Nov 14 2014, 2:34 PM