This is an archive of the discontinued LLVM Phabricator instance.

[CUDA][HIP] Do not diagnose use of _Float16
ClosedPublic

Authored by yaxunl on Jan 28 2019, 9:31 PM.

Details

Summary

r352221 caused regressions in CUDA/HIP since device function may use _Float16 whereas host does not support it.
In this case host compilation should not diagnose usage of _Float16 in device functions or variables.

For now just do not diagnose _Float16 for CUDA/HIP. In the future we should have more precise check.

Diff Detail

Repository
rC Clang

Event Timeline

yaxunl created this revision.Jan 28 2019, 9:31 PM
rjmccall accepted this revision.Jan 28 2019, 9:55 PM

Okay.

This revision is now accepted and ready to land.Jan 28 2019, 9:55 PM
This revision was automatically updated to reflect the committed changes.