This is an archive of the discontinued LLVM Phabricator instance.

[libc++] Fix Windows build error in <functional>
ClosedPublic

Authored by thomasanderson on Jan 28 2019, 1:16 PM.

Details

Summary

On my Windows system, __allocator is defined to nothing. This change fixes build errors of the below form:

In file included from algorithm:644:
functional(1492,31):  error: expected member name or ';' after declaration specifiers
    const _Alloc& __allocator() const { return __f_.second(); }

Diff Detail

Event Timeline

thomasanderson created this revision.Jan 28 2019, 1:16 PM
thomasanderson edited the summary of this revision. (Show Details)Jan 28 2019, 3:25 PM

Please add __allocator to nasty_macros.hpp (https://github.com/llvm-mirror/libcxx/blob/master/test/support/nasty_macros.hpp#L57)

Otherwise, this LGTM.

EricWF accepted this revision.Jan 29 2019, 2:17 PM
This revision is now accepted and ready to land.Jan 29 2019, 2:17 PM
This revision was automatically updated to reflect the committed changes.