This is an archive of the discontinued LLVM Phabricator instance.

[libcxx] Fix SFINAE in <cmath>
ClosedPublic

Authored by K-ballo on Oct 9 2014, 12:57 PM.

Details

Summary

Delay instantiation of __numeric_type within <cmath>, don't instantiate it when the is_arithmetic conditions do not hold as it causes errors with user-defined types with ambiguous conversions. Fixes PR21083

Diff Detail

Event Timeline

K-ballo updated this revision to Diff 14670.Oct 9 2014, 12:57 PM
K-ballo retitled this revision from to [libcxx] Fix SFINAE in <cmath>.
K-ballo updated this object.
K-ballo edited the test plan for this revision. (Show Details)
K-ballo added reviewers: mclow.lists, EricWF.
K-ballo added a subscriber: Unknown Object (MLST).
mclow.lists accepted this revision.Oct 15 2014, 3:32 AM
mclow.lists edited edge metadata.

This looks good to me; thanks.

This revision is now accepted and ready to land.Oct 15 2014, 3:32 AM
EricWF closed this revision.Oct 16 2014, 5:42 PM
EricWF edited edge metadata.

Commited as r219998. Thanks!