This is an archive of the discontinued LLVM Phabricator instance.

[Orc] Resolve crashes in the examples HowToUsejit and Kaleidoscope-Ch4, Kaleidoscope-Ch5, ..., Kaleidoscope-Ch9
Needs ReviewPublic

Authored by damian on Jan 19 2019, 10:12 PM.

Details

Reviewers
gkistanova
rnk
Summary

This is my first review!!

When following the tutorial and came to Kaleidoscope chapter4 the code was crashing when running the following code:
def testfunc(x y) x + y*2;
testfunc(4, 10);

I then patched the code:

  1. Make sure ForceInterpreterLinking is defined, to avoid an error "interpreter has not been linked".
  2. When Finding the symbol we only looked for external functions in Kaleidoscope.

After that the code does on no longer crash.

There is still an issue when entering empty strings, but I a fix for this might come later.

Diff Detail

Repository
rL LLVM

Event Timeline

damian created this revision.Jan 19 2019, 10:12 PM