This is an archive of the discontinued LLVM Phabricator instance.

gn build: unbreak mac (and maybe win) after r351258, r351277
ClosedPublic

Authored by thakis on Jan 17 2019, 8:01 PM.

Details

Summary

The check-hwasan build files assert that current_os == "linux" || current_os == "android", so pull it in only there.

ar is unused on mac, so don't set it in the stage2 toolchain. (It'd be nicer to use llvm-libtool on mac instead of host libtool, but llvm-libtool doesn't seem to understand the -no_warning_for_no_symbols flag.)

Diff Detail

Repository
rL LLVM

Event Timeline

thakis created this revision.Jan 17 2019, 8:01 PM
pcc accepted this revision.Jan 17 2019, 8:08 PM

LGTM

It ought to be possible to cross-compile the Android runtimes on Mac/Win but that can probably be looked into later.

This revision is now accepted and ready to land.Jan 17 2019, 8:08 PM
This revision was automatically updated to reflect the committed changes.