This is an archive of the discontinued LLVM Phabricator instance.

Add ApplePropertyString dump helper to Dwarf.{h|cpp}.
ClosedPublic

Authored by friss on Oct 8 2014, 5:10 PM.

Diff Detail

Repository
rL LLVM

Event Timeline

friss updated this revision to Diff 14615.Oct 8 2014, 5:10 PM
friss retitled this revision from to Add ApplePropertyString dump helper to Dwarf.{h|cpp}..
friss added a reviewer: dblaikie.
friss added a subscriber: Unknown Object (MLST).
dblaikie accepted this revision.Oct 8 2014, 5:14 PM
dblaikie edited edge metadata.

Sure, looks fine.

(this sort of thing can probably go in with usage - so it's tested/exercised/executed - rather than just dead code. It's a tricky balance in terms of commit granularity, though usually a change like this is isolated enough from the (presumably) dwarf dumping code that'll be using it that it doesn't complicate the review)

This revision is now accepted and ready to land.Oct 8 2014, 5:14 PM
friss closed this revision.Oct 9 2014, 1:53 PM
friss updated this revision to Diff 14676.

Closed by commit rL219442 (authored by @friss).