Page MenuHomePhabricator

[LoopReroll] Fix reroll root legality checking.

Authored by efriedma on Jan 16 2019, 2:57 PM.



The code checked that the first root was an appropriate distance from the base value, but skipped checking the other roots. This could lead to rerolling a loop that can't be legally rerolled (at least, not without rewriting the loop in a non-trivial way).

Diff Detail

Event Timeline

efriedma created this revision.Jan 16 2019, 2:57 PM
hfinkel accepted this revision.Jan 26 2019, 7:45 AM


This revision is now accepted and ready to land.Jan 26 2019, 7:45 AM
fhahn accepted this revision.Jan 28 2019, 8:21 AM

LGTM, sorry for the delay!

This revision was automatically updated to reflect the committed changes.
Herald added a project: Restricted Project. · View Herald TranscriptFeb 11 2019, 4:32 PM