Page MenuHomePhabricator

[LoopReroll] Fix reroll root legality checking.
ClosedPublic

Authored by efriedma on Jan 16 2019, 2:57 PM.

Details

Summary

The code checked that the first root was an appropriate distance from the base value, but skipped checking the other roots. This could lead to rerolling a loop that can't be legally rerolled (at least, not without rewriting the loop in a non-trivial way).

Diff Detail

Repository
rL LLVM

Event Timeline

efriedma created this revision.Jan 16 2019, 2:57 PM
hfinkel accepted this revision.Sat, Jan 26, 7:45 AM

LGTM

This revision is now accepted and ready to land.Sat, Jan 26, 7:45 AM
fhahn accepted this revision.Mon, Jan 28, 8:21 AM

LGTM, sorry for the delay!

This revision was automatically updated to reflect the committed changes.
Herald added a project: Restricted Project. · View Herald TranscriptMon, Feb 11, 4:32 PM