Differential D56566

[Legalizer] Use correct ValueType of SELECT_CC node during Float promotion
ClosedPublic
Actions

Authored by pirama on Jan 10 2019, 3:51 PM.

Tags

None

Subscribers

Details

Reviewers

efriedma
majnemer

Commits

rGcc07dabdaa63: [Legalizer] Use correct ValueType of SELECT_CC node during Float promotion
rL350951: [Legalizer] Use correct ValueType of SELECT_CC node during Float promotion

Summary

When legalizing the result of a SELECT_CC node by promoting the
floating-point type, use the promoted-to type rather than the original
type.

Fix PR40273.

Diff Detail

Repository: rL LLVM

Event Timeline

pirama created this revision.Jan 10 2019, 3:51 PM

Harbormaster completed remote builds in B26666: Diff 181178.Jan 10 2019, 3:52 PM

LGTM

This revision is now accepted and ready to land.Jan 10 2019, 3:59 PM

Closed by commit rL350951: [Legalizer] Use correct ValueType of SELECT_CC node during Float promotion (authored by pirama). · Explain WhyJan 11 2019, 10:50 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

llvm/

trunk/

lib/

CodeGen/

SelectionDAG/

LegalizeFloatTypes.cpp

6 lines

test/

CodeGen/

X86/

63 lines

Diff 181323

llvm/trunk/lib/CodeGen/SelectionDAG/LegalizeFloatTypes.cpp

Loading...

llvm/trunk/test/CodeGen/X86/half.ll

Loading...