This is an archive of the discontinued LLVM Phabricator instance.

clang-cl: Fix help text for /O<flags>: '/O2y-' means '/O2 /Oy-', not '/O2 /y-'
ClosedPublic

Authored by thakis on Jan 9 2019, 6:41 AM.

Download Raw Diff

Details

Reviewers

Commits

rGd2a749a92b31: clang-cl: Fix help text for /O<flags>: '/O2y-' means '/O2 /Oy-', not '/O2 /y-'
rC351062: clang-cl: Fix help text for /O<flags>: '/O2y-' means '/O2 /Oy-', not '/O2 /y-'
rL351062: clang-cl: Fix help text for /O<flags>: '/O2y-' means '/O2 /Oy-', not '/O2 /y-'

Diff Detail

Repository: rL LLVM

Event Timeline

thakis created this revision.Jan 9 2019, 6:41 AM

thanks

This revision is now accepted and ready to land.Jan 14 2019, 4:44 AM

Closed by commit rL351062: clang-cl: Fix help text for /O<flags>: '/O2y-' means '/O2 /Oy-', not '/O2 /y-' (authored by nico). · Explain WhyJan 14 2019, 4:46 AM

This revision was automatically updated to reflect the committed changes.

Herald added a subscriber: llvm-commits. · View Herald TranscriptJan 14 2019, 4:46 AM

Revision Contents

Path

Size

cfe/

trunk/

include/

clang/

Driver/

CLCompatOptions.td

2 lines

Diff 181534

cfe/trunk/include/clang/Driver/CLCompatOptions.td

Show First 20 Lines • Show All 110 Lines • ▼ Show 20 Lines	def _SLASH_I : CLJoinedOrSeparate<"I">,
HelpText<"Add directory to include search path">, MetaVarName<"<dir>">,		HelpText<"Add directory to include search path">, MetaVarName<"<dir>">,
Alias<I>;		Alias<I>;
def _SLASH_J : CLFlag<"J">, HelpText<"Make char type unsigned">,		def _SLASH_J : CLFlag<"J">, HelpText<"Make char type unsigned">,
Alias<funsigned_char>;		Alias<funsigned_char>;

// The _SLASH_O option handles all the /O flags, but we also provide separate		// The _SLASH_O option handles all the /O flags, but we also provide separate
// aliased options to provide separate help messages.		// aliased options to provide separate help messages.
def _SLASH_O : CLJoined<"O">,		def _SLASH_O : CLJoined<"O">,
HelpText<"Set multiple /O flags at once; e.g. '/O2y-' is the same as '/O2 /y-'">,		HelpText<"Set multiple /O flags at once; e.g. '/O2y-' for '/O2 /Oy-'">,
MetaVarName<"<flags>">;		MetaVarName<"<flags>">;
// FIXME: Not sure why we have -O0 here; MSVC doesn't support that.		// FIXME: Not sure why we have -O0 here; MSVC doesn't support that.
def : CLFlag<"O0">, Alias<O0>, HelpText<"Disable optimization">;		def : CLFlag<"O0">, Alias<O0>, HelpText<"Disable optimization">;
def : CLFlag<"O1">, Alias<_SLASH_O>, AliasArgs<["1"]>,		def : CLFlag<"O1">, Alias<_SLASH_O>, AliasArgs<["1"]>,
HelpText<"Optimize for size (same as /Og /Os /Oy /Ob2 /GF /Gy)">;		HelpText<"Optimize for size (same as /Og /Os /Oy /Ob2 /GF /Gy)">;
def : CLFlag<"O2">, Alias<_SLASH_O>, AliasArgs<["2"]>,		def : CLFlag<"O2">, Alias<_SLASH_O>, AliasArgs<["2"]>,
HelpText<"Optimize for speed (same as /Og /Oi /Ot /Oy /Ob2 /GF /Gy)">;		HelpText<"Optimize for speed (same as /Og /Oi /Ot /Oy /Ob2 /GF /Gy)">;
def : CLFlag<"Ob0">, Alias<_SLASH_O>, AliasArgs<["b0"]>,		def : CLFlag<"Ob0">, Alias<_SLASH_O>, AliasArgs<["b0"]>,
▲ Show 20 Lines • Show All 312 Lines • Show Last 20 Lines