This is an archive of the discontinued LLVM Phabricator instance.

Differential D56488

clang-cl: Align help texts for /O1 and O2
ClosedPublic

Authored by thakis on Jan 9 2019, 6:33 AM.

Details

Reviewers
hans
Commits
rG1652a63ae102: clang-cl: Align help texts for /O1 and O2
rC351061: clang-cl: Align help texts for /O1 and O2
rL351061: clang-cl: Align help texts for /O1 and O2
Summary

Makes it a bit easier to see what exactly the difference is.

Also use "same as" instead of "equivalent to", because that's faster to read.

Diff Detail

Repository
rL LLVM

Event Timeline

thakis created this revision.Jan 9 2019, 6:33 AM
hans accepted this revision.Jan 14 2019, 4:43 AM

lgtm, thanks

This revision is now accepted and ready to land.Jan 14 2019, 4:43 AM
Closed by commit rL351061: clang-cl: Align help texts for /O1 and O2 (authored by nico). · Explain WhyJan 14 2019, 4:45 AM
This revision was automatically updated to reflect the committed changes.
Herald added a subscriber: llvm-commits. · View Herald TranscriptJan 14 2019, 4:45 AM

Revision Contents

PathSize
cfe/
trunk/
include/
clang/
Driver/
6 lines

Diff 181533

cfe/trunk/include/clang/Driver/CLCompatOptions.td

Show First 20 Lines • Show All 115 Lines • ▼ Show 20 Lines
// The _SLASH_O option handles all the /O flags, but we also provide separate // The _SLASH_O option handles all the /O flags, but we also provide separate
// aliased options to provide separate help messages. // aliased options to provide separate help messages.
def _SLASH_O : CLJoined<"O">, def _SLASH_O : CLJoined<"O">,
HelpText<"Set multiple /O flags at once; e.g. '/O2y-' is the same as '/O2 /y-'">, HelpText<"Set multiple /O flags at once; e.g. '/O2y-' is the same as '/O2 /y-'">,
MetaVarName<"<flags>">; MetaVarName<"<flags>">;
// FIXME: Not sure why we have -O0 here; MSVC doesn't support that. // FIXME: Not sure why we have -O0 here; MSVC doesn't support that.
def : CLFlag<"O0">, Alias<O0>, HelpText<"Disable optimization">; def : CLFlag<"O0">, Alias<O0>, HelpText<"Disable optimization">;
def : CLFlag<"O1">, Alias<_SLASH_O>, AliasArgs<["1"]>, def : CLFlag<"O1">, Alias<_SLASH_O>, AliasArgs<["1"]>,
HelpText<"Optimize for size (equivalent to /Og /Os /Oy /Ob2 /GF /Gy)">; HelpText<"Optimize for size (same as /Og /Os /Oy /Ob2 /GF /Gy)">;
def : CLFlag<"O2">, Alias<_SLASH_O>, AliasArgs<["2"]>, def : CLFlag<"O2">, Alias<_SLASH_O>, AliasArgs<["2"]>,
HelpText<"Optimize for speed (equivalent to /Og /Oi /Ot /Oy /Ob2 /GF /Gy)">; HelpText<"Optimize for speed (same as /Og /Oi /Ot /Oy /Ob2 /GF /Gy)">;
def : CLFlag<"Ob0">, Alias<_SLASH_O>, AliasArgs<["b0"]>, def : CLFlag<"Ob0">, Alias<_SLASH_O>, AliasArgs<["b0"]>,
HelpText<"Disable function inlining">; HelpText<"Disable function inlining">;
def : CLFlag<"Ob1">, Alias<_SLASH_O>, AliasArgs<["b1"]>, def : CLFlag<"Ob1">, Alias<_SLASH_O>, AliasArgs<["b1"]>,
HelpText<"Only inline functions which are (explicitly or implicitly) marked inline">; HelpText<"Only inline functions which are (explicitly or implicitly) marked inline">;
def : CLFlag<"Ob2">, Alias<_SLASH_O>, AliasArgs<["b2"]>, def : CLFlag<"Ob2">, Alias<_SLASH_O>, AliasArgs<["b2"]>,
HelpText<"Inline functions as deemed beneficial by the compiler">; HelpText<"Inline functions as deemed beneficial by the compiler">;
def : CLFlag<"Od">, Alias<_SLASH_O>, AliasArgs<["d"]>, def : CLFlag<"Od">, Alias<_SLASH_O>, AliasArgs<["d"]>,
HelpText<"Disable optimization">; HelpText<"Disable optimization">;
def : CLFlag<"Og">, Alias<_SLASH_O>, AliasArgs<["g"]>, def : CLFlag<"Og">, Alias<_SLASH_O>, AliasArgs<["g"]>,
HelpText<"No effect">; HelpText<"No effect">;
def : CLFlag<"Oi">, Alias<_SLASH_O>, AliasArgs<["i"]>, def : CLFlag<"Oi">, Alias<_SLASH_O>, AliasArgs<["i"]>,
HelpText<"Enable use of builtin functions">; HelpText<"Enable use of builtin functions">;
def : CLFlag<"Oi-">, Alias<_SLASH_O>, AliasArgs<["i-"]>, def : CLFlag<"Oi-">, Alias<_SLASH_O>, AliasArgs<["i-"]>,
HelpText<"Disable use of builtin functions">; HelpText<"Disable use of builtin functions">;
def : CLFlag<"Os">, Alias<_SLASH_O>, AliasArgs<["s"]>, def : CLFlag<"Os">, Alias<_SLASH_O>, AliasArgs<["s"]>,
HelpText<"Optimize for size">; HelpText<"Optimize for size">;
def : CLFlag<"Ot">, Alias<_SLASH_O>, AliasArgs<["t"]>, def : CLFlag<"Ot">, Alias<_SLASH_O>, AliasArgs<["t"]>,
HelpText<"Optimize for speed">; HelpText<"Optimize for speed">;
def : CLFlag<"Ox">, Alias<_SLASH_O>, AliasArgs<["x"]>, def : CLFlag<"Ox">, Alias<_SLASH_O>, AliasArgs<["x"]>,
HelpText<"Deprecated (equivalent to /Og /Oi /Ot /Oy /Ob2); use /O2 instead">; HelpText<"Deprecated (same as /Og /Oi /Ot /Oy /Ob2); use /O2 instead">;
def : CLFlag<"Oy">, Alias<_SLASH_O>, AliasArgs<["y"]>, def : CLFlag<"Oy">, Alias<_SLASH_O>, AliasArgs<["y"]>,
HelpText<"Enable frame pointer omission (x86 only)">; HelpText<"Enable frame pointer omission (x86 only)">;
def : CLFlag<"Oy-">, Alias<_SLASH_O>, AliasArgs<["y-"]>, def : CLFlag<"Oy-">, Alias<_SLASH_O>, AliasArgs<["y-"]>,
HelpText<"Disable frame pointer omission (x86 only, default)">; HelpText<"Disable frame pointer omission (x86 only, default)">;
def _SLASH_QUESTION : CLFlag<"?">, Alias<help>, def _SLASH_QUESTION : CLFlag<"?">, Alias<help>,
HelpText<"Display available options">; HelpText<"Display available options">;
def _SLASH_Qvec : CLFlag<"Qvec">, def _SLASH_Qvec : CLFlag<"Qvec">,
▲ Show 20 Lines • Show All 285 Lines • Show Last 20 Lines