Page MenuHomePhabricator

Documentation: providing a more precise description of a parameter of the kmpc_taskloop function
ClosedPublic

Authored by smateo on Jan 8 2019, 3:32 AM.

Details

Summary

Some time ago I opened the following revision to fix an issue related to the implicit taskgroup associated with a taskloop construct that doesn't have the nogroup clause:

https://bugs.llvm.org/show_bug.cgi?id=37737
https://reviews.llvm.org/D53636

Those changes were upstreamed, but I forgot to update the documentation. This revision tries to address that.

In clang we explicitly materialize the implicit taskgroup when it is required. Thus, we always pass a 1 as the value of the nogroup parameter. Since this parameter doesn't represent whether the nogroup clause was present but whether we want to create a taskgroup region inside the kmpc_taskloop function, I think we should change its description.

Diff Detail

Repository
rL LLVM

Event Timeline

smateo created this revision.Jan 8 2019, 3:32 AM
AndreyChurbanov accepted this revision.Jan 9 2019, 3:34 AM

LG

Sergi, do you have commit rights? I can commit it otherwise. Thanks.

This revision is now accepted and ready to land.Jan 9 2019, 3:34 AM
smateo added a comment.Jan 9 2019, 5:03 AM

Hi Andrey,

I don't, so if you could commit it I'd appreciate it.

Thank you for your time!
Sergi

This revision was automatically updated to reflect the committed changes.