Page MenuHomePhabricator

[SelectionDAG][RFC] Allow the user to specify a memeq function (v2).

Authored by courbet on Jan 4 2019, 2:24 AM.



Right now, when we encounter a string equality check,
e.g. if (memcmp(a, b, s) == 0), we try to expand to a comparison if s is a
small compile-time constant, and fall back on calling memcmp() else.

This is sub-optimal because memcmp has to compute much more than

This patch adds a way for the user to specify a memeq library
function using a module flag, e.g.:

!llvm.module.flags = !{..., !123}
!123 = !{i32 1, !"memeq_lib_function", !"user_memeq"}

This function will be called instead of memcmp() when the result of the memcmp
call is only used for equality comparison.

memeq can be made much more efficient than memcmp because equality
compare is trivially parallel while lexicographic ordering has a chain

Diff Detail

Event Timeline

courbet created this revision.Jan 4 2019, 2:24 AM
courbet updated this revision to Diff 180209.Jan 4 2019, 2:31 AM

update tests

courbet abandoned this revision.Mar 12 2019, 12:26 AM
Herald added a project: Restricted Project. · View Herald TranscriptMar 12 2019, 12:26 AM
Herald added a subscriber: jdoerfert. · View Herald Transcript