This is an archive of the discontinued LLVM Phabricator instance.

Make test/Driver/darwin-sdk-version.c pass if the host triple is 32-bit
ClosedPublic

Authored by thakis on Dec 24 2018, 12:10 PM.

Download Raw Diff

Details

Reviewers

Commits

rG06519794da1a: Make test/Driver/darwin-sdk-version.c pass if the host triple is 32-bit
rC350278: Make test/Driver/darwin-sdk-version.c pass if the host triple is 32-bit
rL350278: Make test/Driver/darwin-sdk-version.c pass if the host triple is 32-bit

Summary

For some reason, the cmake build on my macbook has LLVM_HOST_TRIPLE:STRING=i386-apple-darwin16.7.0 . test/Driver/darwin-sdk-version.c assumed that the host triple is 64-bit, so make it resilient against 32-bit host triples.

Diff Detail

Repository: rL LLVM

Event Timeline

thakis created this revision.Dec 24 2018, 12:10 PM

arphaman: 2019 ping :-)

LGTM

This revision is now accepted and ready to land.Jan 2 2019, 1:23 PM

Closed by commit rL350278: Make test/Driver/darwin-sdk-version.c pass if the host triple is 32-bit (authored by nico). · Explain WhyJan 2 2019, 4:20 PM

This revision was automatically updated to reflect the committed changes.

Herald added a subscriber: llvm-commits. · View Herald TranscriptJan 2 2019, 4:20 PM

Revision Contents

Path

Size

cfe/

trunk/

test/

Driver/

darwin-sdk-version.c

4 lines

Diff 179966

cfe/trunk/test/Driver/darwin-sdk-version.c

	// RUN: %clang -target x86_64-apple-macosx10.13 -isysroot %S/Inputs/MacOSX10.14.sdk -c -### %s 2>&1 \			// RUN: %clang -target x86_64-apple-macosx10.13 -isysroot %S/Inputs/MacOSX10.14.sdk -c -### %s 2>&1 \
	// RUN: \| FileCheck %s			// RUN: \| FileCheck %s
	// RUN: env SDKROOT=%S/Inputs/MacOSX10.14.sdk %clang -target x86_64-apple-macosx10.13 -c -### %s 2>&1 \			// RUN: env SDKROOT=%S/Inputs/MacOSX10.14.sdk %clang -target x86_64-apple-macosx10.13 -c -### %s 2>&1 \
	// RUN: \| FileCheck %s			// RUN: \| FileCheck %s
	//			//
	// RUN: rm -rf %t/SDKs/MacOSX10.10.sdk			// RUN: rm -rf %t/SDKs/MacOSX10.10.sdk
	// RUN: mkdir -p %t/SDKs/MacOSX10.10.sdk			// RUN: mkdir -p %t/SDKs/MacOSX10.10.sdk
	// RUN: %clang -isysroot %t/SDKs/MacOSX10.10.sdk -c -### %s 2>&1 \			// RUN: %clang -m64 -isysroot %t/SDKs/MacOSX10.10.sdk -c -### %s 2>&1 \
	// RUN: \| FileCheck --check-prefix=INFER_SDK_VERSION %s			// RUN: \| FileCheck --check-prefix=INFER_SDK_VERSION %s
	// RUN: sed -e 's/10\.14/10\.8/g' %S/Inputs/MacOSX10.14.sdk/SDKSettings.json > %t/SDKs/MacOSX10.10.sdk/SDKSettings.json			// RUN: sed -e 's/10\.14/10\.8/g' %S/Inputs/MacOSX10.14.sdk/SDKSettings.json > %t/SDKs/MacOSX10.10.sdk/SDKSettings.json
	// RUN: %clang -isysroot %t/SDKs/MacOSX10.10.sdk -c -### %s 2>&1 \			// RUN: %clang -m64 -isysroot %t/SDKs/MacOSX10.10.sdk -c -### %s 2>&1 \
	// RUN: \| FileCheck --check-prefix=INFER_DEPLOYMENT_TARGET_VERSION %s			// RUN: \| FileCheck --check-prefix=INFER_DEPLOYMENT_TARGET_VERSION %s
	// REQUIRES: system-darwin && native			// REQUIRES: system-darwin && native
	//			//
	// RUN: rm -rf %t/SDKs/MacOSX10.14.sdk			// RUN: rm -rf %t/SDKs/MacOSX10.14.sdk
	// RUN: mkdir -p %t/SDKs/MacOSX10.14.sdk			// RUN: mkdir -p %t/SDKs/MacOSX10.14.sdk
	// RUN: %clang -target x86_64-apple-macosx10.13 -isysroot %t/SDKs/MacOSX10.14.sdk -c -### %s 2>&1 \			// RUN: %clang -target x86_64-apple-macosx10.13 -isysroot %t/SDKs/MacOSX10.14.sdk -c -### %s 2>&1 \
	// RUN: \| FileCheck --check-prefix=NO_VERSION %s			// RUN: \| FileCheck --check-prefix=NO_VERSION %s
	//			//
	Show All 18 Lines