This is an archive of the discontinued LLVM Phabricator instance.

[gn build] Make NOSORT line actually work
ClosedPublic

Authored by thakis on Dec 24 2018, 8:11 AM.

Details

Summary

GN wants the NOSORT line to be the first line of a comment block, not the last line.

I sent https://gn-review.googlesource.com/c/gn/+/3560 to support having it in the last line too, but since it will be a while until everyone has that change even if it's expected, use the form that works today.

Diff Detail

Repository
rL LLVM

Event Timeline

thakis created this revision.Dec 24 2018, 8:11 AM
phosek accepted this revision.Dec 24 2018, 2:06 PM

LGTM

This revision is now accepted and ready to land.Dec 24 2018, 2:06 PM
This revision was automatically updated to reflect the committed changes.