This is an archive of the discontinued LLVM Phabricator instance.

[AST] Fix a -Wimplicit-fallthrough warning in ScanfFormatString.cpp
AbandonedPublic

Authored by riccibruno on Dec 21 2018, 7:45 AM.

Details

Reviewers
hans
Summary

This is showing up with some bots
(eg http://lab.llvm.org:8011/builders/clang-atom-d525-fedora-rel/builds/19061/steps/build%20stage%201/logs/warnings%20%284%29)

I am putting this for review since I am not familiar with this code and am not
sure whether adding llvm_unreachable is better than adding a default case
covering the invalid cases, as is done a few lines below.

Diff Detail

Repository
rC Clang

Event Timeline

riccibruno created this revision.Dec 21 2018, 7:45 AM
hans added a comment.Jan 15 2019, 1:37 AM

Sorry for the late reply; I was on vacation. It seems Erich Keane already fixed this in r350941.

riccibruno abandoned this revision.Jan 16 2019, 3:05 PM

Nice, thanks!