Page MenuHomePhabricator

[AArch64] - Return address signing dwarf support
ClosedPublic

Authored by LukeCheeseman on Dec 17 2018, 9:47 AM.

Details

Summary
  • Reapply changes intially introduced in r343089
  • The archtecture info is no longer loaded whenever a DWARFContext is created
  • The runtimes libraries (santiziers) make use of the dwarf context classes but do not intialise the target info
  • The architecture of the object can be obtained without loading the target info
  • Adding a method to the dwarf context to get this information and multiplex the string printing later on

Diff Detail

Repository
rL LLVM

Event Timeline

LukeCheeseman created this revision.Dec 17 2018, 9:47 AM
olista01 accepted this revision.Dec 18 2018, 2:34 AM

LGTM with one nit.

lib/DebugInfo/DWARF/DWARFContext.cpp
1647 ↗(On Diff #178482)

Why is this needed?

This revision is now accepted and ready to land.Dec 18 2018, 2:34 AM
LukeCheeseman marked an inline comment as done.Dec 18 2018, 2:36 AM
LukeCheeseman added inline comments.
lib/DebugInfo/DWARF/DWARFContext.cpp
1647 ↗(On Diff #178482)

Looks like a change that was part of some earlier experimintation, thanks!

This revision was automatically updated to reflect the committed changes.