Page MenuHomePhabricator

Python2/3 compatiility - has_key
ClosedPublic

Authored by serge-sans-paille on Dec 3 2018, 2:37 AM.

Details

Summary

has_key versus in

Diff Detail

Event Timeline

serge-sans-paille retitled this revision from Python2/3 compatiility to Python2/3 compatiility - has_key.Dec 3 2018, 2:51 AM
joerg added a comment.Dec 3 2018, 4:04 AM

LGTM

docs/tools/dump_format_style.py
183

Can you separately adjust the for-loop just above to use a set() and not a list of strings?

serge-sans-paille marked 2 inline comments as done.Dec 10 2018, 1:06 AM
serge-sans-paille added inline comments.
docs/tools/dump_format_style.py
183

I agree with the change, but it's unrelated to the portability issue. Better not mix everything :-)

This revision is now accepted and ready to land.Dec 13 2018, 2:13 AM