Fix a mistake in r217762

[• ehsan]

Summary

The extra macro definition needs to go into COMPILER_RT_GTEST_CFLAGS
in order to be used for gtests on MSVC2012.

[rnk]

lgtm

[timurrrr]

LGTM, I've made similar mistakes like 10 times – looks like these variables are not convenient to use...
The outtake is: try the patch before committing :)

[• ehsan]

In D5493#9, @timurrrr wrote:

LGTM, I've made similar mistakes like 10 times – looks like these variables are not convenient to use...
The outtake is: try the patch before committing :)

Haha! FWIW, I had tried this patch, the issue is that I develop on a VM which doesn't have my real SSH keys so usually I push out my changes to my main machine and submit them from review there, but sometimes for small changes like this, I type in the patch manually for submission, and... I screw things up. :)

[• ehsan]

Closed by commit rL218464 (authored by @ehsan).

cmake/Modules/AddCompilerRT.cmake

if(MSVC)
   list(APPEND COMPILER_RT_GTEST_CFLAGS -DGTEST_HAS_SEH=0)
 
   # gtest use a lot of stuff marked as deprecated on Windows.
   list(APPEND COMPILER_RT_GTEST_CFLAGS -Wno-deprecated-declarations)
 
   # Visual Studio 2012 only supports up to 8 template parameters in
   # std::tr1::tuple by default, but gtest requires 10
   if(MSVC_VERSION EQUAL 1700)
-    add_definitions(-D_VARIADIC_MAX=10)
+    list(APPEND COMPILER_RT_GTEST_CFLAGS -D_VARIADIC_MAX=10)
   endif()
 endif()
 
 # Link objects into a single executable with COMPILER_RT_TEST_COMPILER,
 # using specified link flags. Make executable a part of provided
 # test_suite.
 # add_compiler_rt_test(<test_suite> <test_name>
 #                      OBJECTS <object files>