Page MenuHomePhabricator

[CGP] Improve compile time for complex addressing mode
ClosedPublic

Authored by skatkov on Nov 26 2018, 11:00 PM.

Details

Summary

This is a fix for PR39625 with improvement the compile time
by reducing the number of intermediate Phi nodes created.

Diff Detail

Repository
rL LLVM

Event Timeline

skatkov created this revision.Nov 26 2018, 11:00 PM

This looks good, but I think that some of the comments need to be adjusted as they're no longer accurate for what the code is doing.

lib/CodeGen/CodeGenPrepare.cpp
3020 ↗(On Diff #175405)

This line is no longer relevant, should be deleted.

3047–3069 ↗(On Diff #175405)

This comment needs to be updated so it talks about values, not values in blocks.

3237–3241 ↗(On Diff #175405)

Comment should be adjusted to talk about traversing values, not blocks.

Agreed, I missed comments in hurry. Will update a patch...

skatkov updated this revision to Diff 175616.Nov 27 2018, 6:59 PM

Comments updated.

This revision is now accepted and ready to land.Nov 28 2018, 8:50 AM
This revision was automatically updated to reflect the committed changes.