Page MenuHomePhabricator

Use --push/pop-state with XRay link deps
AbandonedPublic

Authored by phosek on Nov 21 2018, 12:46 AM.

Details

Reviewers
dberris
Summary

XRay runtime link deps handling passes --no-as-needed, but it never
undoes it and this flag may affect other libraries that come later on
the link line. To avoid this, wrap XRay link deps in --push/pop-state.

Diff Detail

Repository
rC Clang

Event Timeline

phosek created this revision.Nov 21 2018, 12:46 AM
dberris accepted this revision.Nov 21 2018, 6:51 PM

LGTM

This revision is now accepted and ready to land.Nov 21 2018, 6:51 PM
phosek abandoned this revision.May 3 2019, 3:20 PM

Turned out this is not the right approach because not every linker supports --push-state/--pop-state but I'm hoping to instead rely on ELF autolinking once D60274 lands.

Herald added a project: Restricted Project. · View Herald TranscriptMay 3 2019, 3:20 PM