Page MenuHomePhabricator

[CodeView] Mark this pointers as const
ClosedPublic

Authored by zturner on Nov 19 2018, 5:08 PM.

Details

Summary

This is for compatibility with MSVC, which also marks them as const. This is a break-off of D54667 to try to get rid of some of the boilerplate from the patch.

Diff Detail

Repository
rL LLVM

Event Timeline

zturner created this revision.Nov 19 2018, 5:08 PM
rnk accepted this revision.Nov 20 2018, 2:07 PM

Right, just for the type of this variables. I... thought we already fixed this? Or maybe I just filed the bug and never actually submitted code to fix it? Whatever, ship the fix and I'll worry about my own deja-vu some other time. lgtm

This revision is now accepted and ready to land.Nov 20 2018, 2:07 PM
rnk added a comment.Nov 20 2018, 2:07 PM

Hey, I'm not crazy: https://bugs.llvm.org/show_bug.cgi?id=36526 I filed the bug but never followed up. Mark it closed for extra points.

This revision was automatically updated to reflect the committed changes.