Page MenuHomePhabricator

[OpenCL] Fix address space deduction in template args
ClosedPublic

Authored by Anastasia on Nov 16 2018, 8:42 AM.

Details

Summary

Don't deduce address spaces for non-pointer-like types in template args.

This fixes bug reported in https://bugs.llvm.org/show_bug.cgi?id=38603 and enables most of template functionality to work correctly.

There is still work to be done on address spaces in TreeTransforms to enable full functionality of address spaces with templates (hence FIXME in the test).

Diff Detail

Repository
rL LLVM

Event Timeline

Anastasia created this revision.Nov 16 2018, 8:42 AM
rjmccall accepted this revision.Nov 16 2018, 11:46 AM

Makes sense.

This revision is now accepted and ready to land.Nov 16 2018, 11:46 AM
This revision was automatically updated to reflect the committed changes.