This is an archive of the discontinued LLVM Phabricator instance.

[X86] Remove ANY_EXTEND special case from canReduceVMulWidth
ClosedPublic

Authored by craig.topper on Nov 15 2018, 12:21 PM.

Details

Summary

Removing this code doesn't affect any lit tests so it doesn't appear to be tested anymore. I assume it was when it was added, but I guess something else changed?

I mostly didn't like that it seemed to count the sign bits as if it was a sign_extend, but then set isPositive as if it was a zero_extend. It feels like we should have picked one interpretation?

Diff Detail

Repository
rL LLVM

Event Timeline

craig.topper created this revision.Nov 15 2018, 12:21 PM
RKSimon accepted this revision.Nov 15 2018, 12:56 PM

LGTM - code coverage report says its unused as well

This revision is now accepted and ready to land.Nov 15 2018, 12:56 PM
This revision was automatically updated to reflect the committed changes.