This is an archive of the discontinued LLVM Phabricator instance.

ms-inline-asm: Add a test case for the usage of labels in bracket expressions
ClosedPublic

Authored by ehsan on Sep 22 2014, 12:51 PM.

Diff Detail

Repository
rL LLVM

Event Timeline

ehsan updated this revision to Diff 13950.Sep 22 2014, 12:51 PM
ehsan retitled this revision from to ms-inline-asm: Add a test case for the usage of labels in bracket expressions.
ehsan updated this object.
ehsan edited the test plan for this revision. (Show Details)
ehsan added a reviewer: rnk.
ehsan added a subscriber: Unknown Object (MLST).
rnk accepted this revision.Sep 22 2014, 1:48 PM
rnk edited edge metadata.

lgtm

test/CodeGen/ms-inline-asm.c
554 ↗(On Diff #13950)

Interesting. I would've expected this to be a load, not a lea-like thing.

This revision is now accepted and ready to land.Sep 22 2014, 1:48 PM
ehsan added inline comments.Sep 22 2014, 1:51 PM
test/CodeGen/ms-inline-asm.c
554 ↗(On Diff #13950)

This is what MSVC does, AFAICT.

ehsan closed this revision.Sep 22 2014, 1:51 PM
ehsan updated this revision to Diff 13958.

Closed by commit rL218271 (authored by @ehsan).