This is an archive of the discontinued LLVM Phabricator instance.

Return true from UnifySection when emitting a diagnostic
ClosedPublic

Authored by • ehsan on Sep 22 2014, 9:16 AM.

Reviewers

majnemer
rnk

Commits

• ehsan retitled this revision from to Return true from UnifySection when emitting a diagnostic.

• ehsan updated this object.

• ehsan edited the test plan for this revision. (Show Details)

• ehsan added a reviewer: majnemer.

• ehsan added a subscriber: Unknown Object (MLST).

Woops. lgtm

This revision is now accepted and ready to land.Sep 22 2014, 9:34 AM

Closed by commit rL218265 (authored by @ehsan).

Path

Size

cfe/

trunk/

lib/

Sema/

2 lines

Show First 20 Lines • Show All 378 Lines • ▼ Show 20 Lines	bool Sema::UnifySection(StringRef SectionName,
Diag(OtherDecl->getLocation(), diag::note_declared_at)		Diag(OtherDecl->getLocation(), diag::note_declared_at)
<< OtherDecl->getName();		<< OtherDecl->getName();
if (auto A = Decl->getAttr<SectionAttr>())		if (auto A = Decl->getAttr<SectionAttr>())
if (A->isImplicit())		if (A->isImplicit())
Diag(A->getLocation(), diag::note_pragma_entered_here);		Diag(A->getLocation(), diag::note_pragma_entered_here);
if (auto A = OtherDecl->getAttr<SectionAttr>())		if (auto A = OtherDecl->getAttr<SectionAttr>())
if (A->isImplicit())		if (A->isImplicit())
Diag(A->getLocation(), diag::note_pragma_entered_here);		Diag(A->getLocation(), diag::note_pragma_entered_here);
return false;		return true;
}		}

bool Sema::UnifySection(StringRef SectionName,		bool Sema::UnifySection(StringRef SectionName,
int SectionFlags,		int SectionFlags,
SourceLocation PragmaSectionLocation) {		SourceLocation PragmaSectionLocation) {
auto Section = SectionInfos.find(SectionName);		auto Section = SectionInfos.find(SectionName);
if (Section != SectionInfos.end()) {		if (Section != SectionInfos.end()) {
if (Section->second.SectionFlags == SectionFlags)		if (Section->second.SectionFlags == SectionFlags)
▲ Show 20 Lines • Show All 221 Lines • Show Last 20 Lines