Page MenuHomePhabricator

[clang-tidy] Add a checker that warns on TODO comments without username.

Authored by bkramer on Sep 18 2014, 5:23 AM.

Diff Detail


Event Timeline

bkramer updated this revision to Diff 13827.Sep 18 2014, 5:23 AM
bkramer retitled this revision from to [clang-tidy] Add a checker that warns on TODO comments without username..
bkramer added a reviewer: alexfh.
bkramer updated this object.
bkramer added a subscriber: Unknown Object (MLST).
alexfh accepted this revision.Sep 18 2014, 5:47 AM
alexfh edited edge metadata.

Looks good provided that you fix the issues.

54 ↗(On Diff #13827)

This could be a reference as well.

5 ↗(On Diff #13827)

It should be CHECK-MESSAGES:

6 ↗(On Diff #13827)

Please make the comments distinct, so that they can be matched reliably. Currently, the test can pass even if one of the replacement is not done, as there's a matching string in line 24.

This revision is now accepted and ready to land.Sep 18 2014, 5:47 AM
Diffusion closed this revision.Sep 18 2014, 6:03 AM
Diffusion updated this revision to Diff 13829.

Closed by commit rL218049 (authored by d0k).

kimgr added a subscriber: kimgr.Sep 21 2014, 12:21 PM

See inline.


This doesn't work on Windows. The variable there is USERNAME; would it make sense to check both?


Thanks for noting. Some further work on this is happening in D5408, and I'll add USERNAME variable handling there.